Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tool/input_sdk/patch/core_patch.dart

Issue 1093353004: fix list initializers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: baselines Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/generated_sdk/lib/core/list.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/patch/core_patch.dart
diff --git a/tool/input_sdk/patch/core_patch.dart b/tool/input_sdk/patch/core_patch.dart
index c06fd8f82aace62f03d72ff43d32746b370f830d..ddd7e0a2ce7e7d8c9b062fb0fe34cce32488f2f5 100644
--- a/tool/input_sdk/patch/core_patch.dart
+++ b/tool/input_sdk/patch/core_patch.dart
@@ -117,9 +117,7 @@ class int {
static int parse(String source,
{ int radix,
int onError(String source) }) {
- // TODO(jmesserly): fix this
- return JS('int', 'Number(#)', source);
- //return Primitives.parseInt(source, radix, onError);
+ return Primitives.parseInt(source, radix, onError);
}
@patch
@@ -264,16 +262,12 @@ class List<E> {
@patch
factory List.from(Iterable elements, { bool growable: true }) {
- // TODO(jmesserly): fix this. This is just to unblock initial SDK check in.
- return null;
- /*
List<E> list = new List<E>();
for (E e in elements) {
list.add(e);
}
if (growable) return list;
return makeListFixedLength(list);
- */
}
}
« no previous file with comments | « test/generated_sdk/lib/core/list.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698