[es6] Map/Set size getter should have "get size" name

[es6] Map/Set size getter should have "get size" name

This reverts commit d5565c1f689b2953d92abd350529363f04f90fcd.

Getter and setter function names in ES6 are defined as "get foo" and
"set foo".

This also moves the logic for handling symbols from runtime-function.cc
to v8natives.js.

BUG=None
LOG=N
R=adamk@chromium.org

Committed: https://crrev.com/2279dfe7890f4cbe63f1ee9adb290a533d9a2c20
Cr-Commit-Position: refs/heads/master@{#28050}

[arv (Not doing code reviews), 2015-04-24 15:25:27]

Move the string flattening to v8natives.js

[arv (Not doing code reviews), 2015-04-24 15:26:53]

Original revert is in patch set 1.

Changes are in patch set 2. The difference is that FlattenString is moved to
v8natives.js. This way we don't need to call it in the common case and it should
fix the execution order that GCMole complained about.

[arv (Not doing code reviews), 2015-04-24 15:27:05]

arv@chromium.org changed reviewers:
+ caitpotter88@gmail.com

[arv (Not doing code reviews), 2015-04-24 15:27:05]

PTAL

[adamk, 2015-04-24 15:40:36]

I'd prefer the original patch's approach (flattening the string in C++) and just
fixing the GCMole problem. This use of %FlattenString is not intuitive (and it
seems to be the first use of %FlattenString in non-test JS).

[arv (Not doing code reviews), 2015-04-24 15:53:58]

Moved the flatten back to the runtime but restructured the code slightly

[arv (Not doing code reviews), 2015-04-24 15:55:24]

PTAL

[adamk, 2015-04-24 16:06:53]

https://codereview.chromium.org/1093183006/diff/30001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1093183006/diff/30001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:96:
f->shared()->set_name(*NameToFunctionName(name));
The solution is to put this on two lines:

name = NameToFunctionName(name);
set_name(*name);

[arv (Not doing code reviews), 2015-04-24 16:20:11]

NameToFunctionName might allocate now so we need to be careful about execution
order

[arv (Not doing code reviews), 2015-04-24 16:26:30]

cleanup

[arv (Not doing code reviews), 2015-04-24 16:28:09]

PTAL

[adamk, 2015-04-24 16:29:07]

lgtm

Do with the comment what you will.

https://codereview.chromium.org/1093183006/diff/50001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1093183006/diff/50001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:96: // NameToFunctionName may cause allocations
so we need to be careful about
Not sure this comment adds much, I'd tend to expect that functions dealing in
handles might allocate (basically the old code was already bad form).

[arv (Not doing code reviews), 2015-04-24 16:29:52]

Remove comment

[arv (Not doing code reviews), 2015-04-24 16:31:26]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-04-24 16:31:26]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1093183006/#ps90001
(title: "Remove comment")

[commit-bot: I haz the power, 2015-04-24 16:31:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1093183006/90001

[arv (Not doing code reviews), 2015-04-24 16:56:12]

The CQ bit was unchecked by arv@chromium.org

[arv (Not doing code reviews), 2015-04-24 17:02:13]

Implement ES6 SetFunctionName correctly

[arv (Not doing code reviews), 2015-04-24 17:04:51]

Use IS_UNDEFINED instead

[arv (Not doing code reviews), 2015-04-24 17:06:02]

I ended up taking care of Caitlin's TODO and just implemented the ES6 spec
algorithm for SetFunctionName.

PTAL

[caitp (gmail), 2015-04-24 17:13:51]

On 2015/04/24 17:06:02, arv wrote:
> I ended up taking care of Caitlin's TODO and just implemented the ES6 spec
> algorithm for SetFunctionName.
> 
> PTAL

[caitp (gmail), 2015-04-24 17:14:40]

On 2015/04/24 17:13:51, caitp wrote:
> On 2015/04/24 17:06:02, arv wrote:
> > I ended up taking care of Caitlin's TODO and just implemented the ES6 spec
> > algorithm for SetFunctionName.
> > 
> > PTAL

It still looks okay to me

[adamk, 2015-04-24 17:35:37]

lgtm

[arv (Not doing code reviews), 2015-04-24 17:48:51]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-04-24 17:49:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1093183006/130001

[commit-bot: I haz the power, 2015-04-24 18:16:25]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2015-04-24 18:16:36]

Patchset 8 (id:??) landed as
https://crrev.com/2279dfe7890f4cbe63f1ee9adb290a533d9a2c20
Cr-Commit-Position: refs/heads/master@{#28050}

[Michael Achenbach, 2015-04-24 19:47:36]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2015-04-24 19:47:36]

[Sheriff] Please land a blink-side needsmanualrebaseline for the expectation
change of inspector/console/console-format.html or revert.

See e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3102

[arv (Not doing code reviews), 2015-04-24 20:00:53]

On 2015/04/24 19:47:36, Michael Achenbach wrote:
> [Sheriff] Please land a blink-side needsmanualrebaseline for the expectation
> change of inspector/console/console-format.html or revert.
> 
> See e.g.:
>
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3102

I'm adding the exception.

[arv (Not doing code reviews), 2015-04-24 20:00:53]

On 2015/04/24 19:47:36, Michael Achenbach wrote:
> [Sheriff] Please land a blink-side needsmanualrebaseline for the expectation
> change of inspector/console/console-format.html or revert.
> 
> See e.g.:
>
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3102

I'm adding the exception.