Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/runtime/runtime-function.cc

Issue 1093183006: [es6] Map/Set size getter should have "get size" name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use IS_UNDEFINED instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/i18n.js ('k') | src/string-iterator.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/cpu-profiler.h" 10 #include "src/cpu-profiler.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 RUNTIME_FUNCTION(Runtime_FunctionGetName) { 62 RUNTIME_FUNCTION(Runtime_FunctionGetName) {
63 SealHandleScope shs(isolate); 63 SealHandleScope shs(isolate);
64 DCHECK(args.length() == 1); 64 DCHECK(args.length() == 1);
65 65
66 CONVERT_ARG_CHECKED(JSFunction, f, 0); 66 CONVERT_ARG_CHECKED(JSFunction, f, 0);
67 return f->shared()->name(); 67 return f->shared()->name();
68 } 68 }
69 69
70 70
71 static Handle<String> NameToFunctionName(Handle<Name> name) {
72 Handle<String> stringName(name->GetHeap()->empty_string());
73
74 // TODO(caitp): Follow proper rules in section 9.2.11 (SetFunctionName)
75 if (name->IsSymbol()) {
76 Handle<Object> description(Handle<Symbol>::cast(name)->name(),
77 name->GetIsolate());
78 if (description->IsString()) {
79 stringName = Handle<String>::cast(description);
80 }
81 } else {
82 stringName = Handle<String>::cast(name);
83 }
84
85 return stringName;
86 }
87
88
89 RUNTIME_FUNCTION(Runtime_FunctionSetName) { 71 RUNTIME_FUNCTION(Runtime_FunctionSetName) {
90 HandleScope scope(isolate); 72 HandleScope scope(isolate);
91 DCHECK(args.length() == 2); 73 DCHECK(args.length() == 2);
92 74
93 CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0); 75 CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0);
94 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); 76 CONVERT_ARG_HANDLE_CHECKED(String, name, 1);
95 77
96 f->shared()->set_name(*NameToFunctionName(name)); 78 name = String::Flatten(name);
79 f->shared()->set_name(*name);
97 return isolate->heap()->undefined_value(); 80 return isolate->heap()->undefined_value();
98 } 81 }
99 82
100 83
101 RUNTIME_FUNCTION(Runtime_FunctionNameShouldPrintAsAnonymous) { 84 RUNTIME_FUNCTION(Runtime_FunctionNameShouldPrintAsAnonymous) {
102 SealHandleScope shs(isolate); 85 SealHandleScope shs(isolate);
103 DCHECK(args.length() == 1); 86 DCHECK(args.length() == 1);
104 CONVERT_ARG_CHECKED(JSFunction, f, 0); 87 CONVERT_ARG_CHECKED(JSFunction, f, 0);
105 return isolate->heap()->ToBoolean( 88 return isolate->heap()->ToBoolean(
106 f->shared()->name_should_print_as_anonymous()); 89 f->shared()->name_should_print_as_anonymous());
(...skipping 535 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 625
643 626
644 RUNTIME_FUNCTION(Runtime_IsFunction) { 627 RUNTIME_FUNCTION(Runtime_IsFunction) {
645 SealHandleScope shs(isolate); 628 SealHandleScope shs(isolate);
646 DCHECK(args.length() == 1); 629 DCHECK(args.length() == 1);
647 CONVERT_ARG_CHECKED(Object, obj, 0); 630 CONVERT_ARG_CHECKED(Object, obj, 0);
648 return isolate->heap()->ToBoolean(obj->IsJSFunction()); 631 return isolate->heap()->ToBoolean(obj->IsJSFunction());
649 } 632 }
650 } 633 }
651 } // namespace v8::internal 634 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/i18n.js ('k') | src/string-iterator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698