Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: src/runtime/runtime-function.cc

Issue 1093183006: [es6] Map/Set size getter should have "get size" name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use IS_UNDEFINED instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/i18n.js ('k') | src/string-iterator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-function.cc
diff --git a/src/runtime/runtime-function.cc b/src/runtime/runtime-function.cc
index c211e1895f742408281a18f4de7db6b77bcdd202..e0be0698fec13998728c920eb0d390b1e2fbec7b 100644
--- a/src/runtime/runtime-function.cc
+++ b/src/runtime/runtime-function.cc
@@ -68,32 +68,15 @@ RUNTIME_FUNCTION(Runtime_FunctionGetName) {
}
-static Handle<String> NameToFunctionName(Handle<Name> name) {
- Handle<String> stringName(name->GetHeap()->empty_string());
-
- // TODO(caitp): Follow proper rules in section 9.2.11 (SetFunctionName)
- if (name->IsSymbol()) {
- Handle<Object> description(Handle<Symbol>::cast(name)->name(),
- name->GetIsolate());
- if (description->IsString()) {
- stringName = Handle<String>::cast(description);
- }
- } else {
- stringName = Handle<String>::cast(name);
- }
-
- return stringName;
-}
-
-
RUNTIME_FUNCTION(Runtime_FunctionSetName) {
HandleScope scope(isolate);
DCHECK(args.length() == 2);
CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0);
- CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
+ CONVERT_ARG_HANDLE_CHECKED(String, name, 1);
- f->shared()->set_name(*NameToFunctionName(name));
+ name = String::Flatten(name);
+ f->shared()->set_name(*name);
return isolate->heap()->undefined_value();
}
« no previous file with comments | « src/i18n.js ('k') | src/string-iterator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698