Issue 10926: Place all new baseline files in the most specific platform directory....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10926: Place all new baseline files in the most specific platform directory.... (Closed)

Created:
12 years, 1 month ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Place all new baseline files in the most specific platform directory. The --new-baseline option no longer takes a directory name. BUG=4408 TEST=try re-baselining a file, make sure results go in the right place Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5524

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -42 lines)			Patch
M	webkit/tools/layout_tests/layout_package/path_utils.py	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	webkit/tools/layout_tests/run_webkit_tests.py	View	3 chunks	+10 lines, -12 lines	1 comment	Download
M	webkit/tools/layout_tests/test_types/image_diff.py	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	webkit/tools/layout_tests/test_types/simplified_text_diff.py	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	webkit/tools/layout_tests/test_types/test_type_base.py	View	2 chunks	+14 lines, -18 lines	0 comments	Download
M	webkit/tools/layout_tests/test_types/text_diff.py	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

12 years, 1 month ago (2008-11-14 04:45:42 UTC) #2

LGTM, thanks for doing this!

http://codereview.chromium.org/10926/diff/1/7
File webkit/tools/layout_tests/layout_package/path_utils.py (right):

http://codereview.chromium.org/10926/diff/1/7#newcode64
Line 64: PathNotFound if we're unable to find it."""
Nit: This method doesn't actually check to see if the path exists so it won't
raise PathNotFound (unless LayoutDataDir() isn't found).  I would probably just
change the comment.

http://codereview.chromium.org/10926/diff/1/2
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/10926/diff/1/2#newcode571
Line 571: "into the platform directory , overwriting "
Nit: space before comma.

Expand Messages | Collapse Messages