Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: webkit/tools/layout_tests/test_types/image_diff.py

Issue 10926: Place all new baseline files in the most specific platform directory.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/layout_tests/test_types/image_diff.py
===================================================================
--- webkit/tools/layout_tests/test_types/image_diff.py (revision 5432)
+++ webkit/tools/layout_tests/test_types/image_diff.py (working copy)
@@ -39,20 +39,19 @@
if errno.ENOENT != e.errno:
raise
- def _SaveBaselineFiles(self, filename, dest_dir, png_path, checksum):
+ def _SaveBaselineFiles(self, filename, png_path, checksum):
"""Saves new baselines for the PNG and checksum.
Args:
filename: test filename
- dest_dir: outer directory into which the results should be saved.
png_path: path to the actual PNG result file
checksum: value of the actual checksum result
"""
png_file = open(png_path, "rb")
png_data = png_file.read()
png_file.close()
- self._SaveBaselineData(filename, dest_dir, png_data, ".png")
- self._SaveBaselineData(filename, dest_dir, checksum, ".checksum")
+ self._SaveBaselineData(filename, png_data, ".png")
+ self._SaveBaselineData(filename, checksum, ".checksum")
def CompareOutput(self, filename, proc, output, test_args):
"""Implementation of CompareOutput that checks the output image and
@@ -66,8 +65,7 @@
# If we're generating a new baseline, we pass.
if test_args.new_baseline:
- self._SaveBaselineFiles(filename, test_args.new_baseline,
- test_args.png_path, test_args.hash)
+ self._SaveBaselineFiles(filename, test_args.png_path, test_args.hash)
return failures
# Compare hashes.

Powered by Google App Engine
This is Rietveld 408576698