Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: webkit/tools/layout_tests/layout_package/path_utils.py

Issue 10926: Place all new baseline files in the most specific platform directory.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Some utility methods for getting paths used by run_webkit_tests.py. 5 """Some utility methods for getting paths used by run_webkit_tests.py.
6 """ 6 """
7 7
8 import errno 8 import errno
9 import os 9 import os
10 import platform_utils 10 import platform_utils
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 def ChromiumPlatformResultsDir(): 54 def ChromiumPlatformResultsDir():
55 """Returns the full path to the directory containing Chromium platform 55 """Returns the full path to the directory containing Chromium platform
56 result directories. Raises PathNotFound if we're unable to find it. 56 result directories. Raises PathNotFound if we're unable to find it.
57 """ 57 """
58 # TODO(pamg): Once we move platform/chromium-* into LayoutTests/platform/, 58 # TODO(pamg): Once we move platform/chromium-* into LayoutTests/platform/,
59 # remove this and use PlatformResultsDir() for everything. 59 # remove this and use PlatformResultsDir() for everything.
60 return os.path.join(LayoutDataDir(), 'platform') 60 return os.path.join(LayoutDataDir(), 'platform')
61 61
62 def WebKitPlatformResultsDir(): 62 def WebKitPlatformResultsDir():
63 """Gets the full path to the platform results directory. Raises 63 """Gets the full path to just above the platform results directory. Raises
64 PathNotFound if we're unable to find it.""" 64 PathNotFound if we're unable to find it."""
tony 2008/11/14 04:45:42 Nit: This method doesn't actually check to see if
65 return os.path.join(LayoutDataDir(), 'LayoutTests', 'platform') 65 return os.path.join(LayoutDataDir(), 'LayoutTests', 'platform')
66 66
67 def PlatformResultsDir(platform): 67 def PlatformResultsDir(platform):
68 """Gets the full path to the results directory for this platform.""" 68 """Gets the path to just above the results directory for this platform."""
69 if platform.startswith('chromium'): 69 if platform.startswith('chromium'):
70 return ChromiumPlatformResultsDir() 70 return ChromiumPlatformResultsDir()
71 return WebKitPlatformResultsDir() 71 return WebKitPlatformResultsDir()
72 72
73 def ExpectedFilename(filename, suffix, platform): 73 def ExpectedFilename(filename, suffix, platform):
74 """Given a test name, returns an absolute path to its expected results. 74 """Given a test name, returns an absolute path to its expected results.
75 75
76 The result will be sought in the hierarchical platform directories, in the 76 The result will be sought in the hierarchical platform directories, in the
77 corresponding WebKit platform directories, in the WebKit platform/mac/ 77 corresponding WebKit platform directories, in the WebKit platform/mac/
78 directory, and finally next to the test file. 78 directory, and finally next to the test file.
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 return GetPlatformUtil().GetAbsolutePath(path) 192 return GetPlatformUtil().GetAbsolutePath(path)
193 193
194 def FilenameToUri(path): 194 def FilenameToUri(path):
195 return GetPlatformUtil().FilenameToUri(path) 195 return GetPlatformUtil().FilenameToUri(path)
196 196
197 def TestListPlatformDir(): 197 def TestListPlatformDir():
198 return GetPlatformUtil().TestListPlatformDir() 198 return GetPlatformUtil().TestListPlatformDir()
199 199
200 def PlatformDir(): 200 def PlatformDir():
201 return GetPlatformUtil().PlatformDir() 201 return GetPlatformUtil().PlatformDir()
OLDNEW
« no previous file with comments | « no previous file | webkit/tools/layout_tests/run_webkit_tests.py » ('j') | webkit/tools/layout_tests/run_webkit_tests.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698