Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1092193004: Use related_applications manifest fields when showing native app banners (Closed)

Created:
5 years, 8 months ago by benwells
Modified:
5 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use related_applications manifest fields when showing native app banners Previously meta tags were used. This change updates the native app banner code to use the new related-applications and prefer_related_applications fields of the manifest instead. BUG=457403 Committed: https://crrev.com/51f7dbdc3d92a014d96f13c3193fed86cd063463 Cr-Commit-Position: refs/heads/master@{#326383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -94 lines) Patch
M chrome/browser/android/banners/app_banner_manager_android.h View 1 chunk +4 lines, -14 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 3 chunks +16 lines, -46 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher_browsertest.cc View 5 chunks +32 lines, -16 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/banners/app_banner_manager.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
A chrome/test/data/android/banners/native_app_manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/data/android/banners/native_app_test.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/banners/play_app_manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
A + chrome/test/data/banners/play_app_test_page.html View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
benwells
5 years, 8 months ago (2015-04-22 07:36:45 UTC) #2
gone
lgtm Wonder if it makes sense to combine the test HTML and JSON files at ...
5 years, 8 months ago (2015-04-22 18:55:30 UTC) #3
benwells
On 2015/04/22 18:55:30, dfalcantara wrote: > lgtm > > Wonder if it makes sense to ...
5 years, 8 months ago (2015-04-22 21:50:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092193004/1
5 years, 8 months ago (2015-04-22 21:57:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 22:43:18 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 22:45:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f7dbdc3d92a014d96f13c3193fed86cd063463
Cr-Commit-Position: refs/heads/master@{#326383}

Powered by Google App Engine
This is Rietveld 408576698