Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1092193004: Use related_applications manifest fields when showing native app banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 085e920d4e4c47f5ef11cdcce145be663b246045..ce6d8e3013fe178b19e22b6ac4aabc99beaf38dd 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -43,9 +43,11 @@ class AppBannerDataFetcher
class Delegate {
public:
- // Called when no valid manifest was found. Returns |true| if the fetcher
- // needs to remain active and wait for a callback.
- virtual bool OnInvalidManifest(AppBannerDataFetcher* fetcher) = 0;
+ // Called to handle a non-web app. Returns |true| if the non-web app can be
+ // handled, and the fetcher needs to remain active and wait for a callback.
+ virtual bool HandleNonWebApp(const std::string& platform,
+ const GURL& url,
+ const std::string& id) = 0;
};
// Returns the current time.
@@ -137,7 +139,7 @@ class AppBannerDataFetcher
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
- static bool IsManifestValid(const content::Manifest& manifest);
+ static bool IsManifestValidForWebApp(const content::Manifest& manifest);
const int ideal_icon_size_;
const base::WeakPtr<Delegate> weak_delegate_;
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698