chrome/browser/banners/app_banner_data_fetcher_unittest.cc - Issue 1092193004: Use related_applications manifest fields when showing native app banners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

Issue 1092193004: Use related_applications manifest fields when showing native app banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc

index d662c8051a12f74c0b3359a61f1450f7673c4f95..2254130433b6c01e5066a7bc7d6489e2f5686cfa 100644

--- a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc

@@ -33,7 +33,7 @@ class AppBannerDataFetcherUnitTest : public testing::Test {

}

static bool IsManifestValid(const content::Manifest& manifest) {

- return AppBannerDataFetcher::IsManifestValid(manifest);

+ return AppBannerDataFetcher::IsManifestValidForWebApp(manifest);

}

};

« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher_browsertest.cc ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »