Always include base extension type in Mac select file dialog

Always include base extension type in Mac select file dialog

Previously, we were only converting the extension to a UTI, and using that to control what files the user could load using the generic select file dialog. For some reason, Mac's conversions of some types - such as '.ogg' - resulted in a UTI prefixed with 'dyn' that didn't seem to correspond back to '.ogg' itself.

The solution here is just to always include the original extension as well as the UTI. FWIW, the rest of this file needs updating to support lots of more complex things we now do with Packaged Apps.

BUG=148840
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157332

[thorogood, 2012-09-13 04:50:14]

benwells: chrome/browser/extensions/api/file_system
thakis: ui/base/dialogs (i.e., the .mm change)

Thanks! :)

[Nico, 2012-09-13 04:52:16]

+avi for the select_file_dialog change

[benwells, 2012-09-13 05:41:17]

file_system_api lgtm

[Avi (use Gerrit), 2012-09-13 05:52:38]

https://codereview.chromium.org/10915252/diff/1/ui/base/dialogs/select_file_d...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

https://codereview.chromium.org/10915252/diff/1/ui/base/dialogs/select_file_d...
ui/base/dialogs/select_file_dialog_mac.mm:234: [file_type_set
addObject:base::mac::CFToNSCast(ext_cf.get())];
UTIs always exist. Dynamic UTIs exist to round-trip for exactly this purpose.
This sounds like a bug, either on our end or Apple's. Can you pull this out into
a small test app so we can file a bug with Apple?

[thorogood, 2012-09-16 22:49:53]

On 2012/09/13 05:52:38, Avi wrote:
>
https://codereview.chromium.org/10915252/diff/1/ui/base/dialogs/select_file_d...
> File ui/base/dialogs/select_file_dialog_mac.mm (right):
> 
>
https://codereview.chromium.org/10915252/diff/1/ui/base/dialogs/select_file_d...
> ui/base/dialogs/select_file_dialog_mac.mm:234: [file_type_set
> addObject:base::mac::CFToNSCast(ext_cf.get())];
> UTIs always exist. Dynamic UTIs exist to round-trip for exactly this purpose.
> This sounds like a bug, either on our end or Apple's. Can you pull this out
into
> a small test app so we can file a bug with Apple?

I'll give it a go today. FWIW, I'm testing on 10.8.1.

[thorogood, 2012-09-16 23:50:49]

Avi, do you feel like we could submit this change anyway, and just revert it
if/when Apple fixes the bug on their end?

https://chromiumcodereview.appspot.com/10915252/diff/1/ui/base/dialogs/select...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

https://chromiumcodereview.appspot.com/10915252/diff/1/ui/base/dialogs/select...
ui/base/dialogs/select_file_dialog_mac.mm:234: [file_type_set
addObject:base::mac::CFToNSCast(ext_cf.get())];
On 2012/09/13 05:52:39, Avi wrote:
> UTIs always exist. Dynamic UTIs exist to round-trip for exactly this purpose.
> This sounds like a bug, either on our end or Apple's. Can you pull this out
into
> a small test app so we can file a bug with Apple?

Done, I've attached it to the bug (which I've CC'ed you on).

[Avi (use Gerrit), 2012-09-17 02:41:45]

lgtm

https://chromiumcodereview.appspot.com/10915252/diff/1/ui/base/dialogs/select...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

https://chromiumcodereview.appspot.com/10915252/diff/1/ui/base/dialogs/select...
ui/base/dialogs/select_file_dialog_mac.mm:234: [file_type_set
addObject:base::mac::CFToNSCast(ext_cf.get())];
What The F. Can you link the bug in the comment?

[thorogood, 2012-09-17 03:19:06]

thakis@, can you approve?

https://chromiumcodereview.appspot.com/10915252/diff/1/ui/base/dialogs/select...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

https://chromiumcodereview.appspot.com/10915252/diff/1/ui/base/dialogs/select...
ui/base/dialogs/select_file_dialog_mac.mm:234: [file_type_set
addObject:base::mac::CFToNSCast(ext_cf.get())];
On 2012/09/17 02:41:45, Avi wrote:
> What The F. Can you link the bug in the comment?

Done, linked to the issue 148840.

[Nico, 2012-09-17 08:03:33]

https://chromiumcodereview.appspot.com/10915252/diff/4/ui/base/dialogs/select...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

https://chromiumcodereview.appspot.com/10915252/diff/4/ui/base/dialogs/select...
ui/base/dialogs/select_file_dialog_mac.mm:235: [file_type_set
addObject:base::mac::CFToNSCast(ext_cf.get())];
Did you file a bug with apple (bugreport.apple.com and then
openradar.appspot.com)? Can you link to that too?

[thorogood, 2012-09-18 02:12:25]

https://chromiumcodereview.appspot.com/10915252/diff/4/ui/base/dialogs/select...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

https://chromiumcodereview.appspot.com/10915252/diff/4/ui/base/dialogs/select...
ui/base/dialogs/select_file_dialog_mac.mm:235: [file_type_set
addObject:base::mac::CFToNSCast(ext_cf.get())];
On 2012/09/17 08:03:33, Nico wrote:
> Did you file a bug with apple (http://bugreport.apple.com and then
> openradar.appspot.com)? Can you link to that too?

Done and done.

[Avi (use Gerrit), 2012-09-18 02:46:05]

Sigh. C'est la vie. LGTM

[Nico, 2012-09-18 04:38:55]

lgtm, thanks

[commit-bot: I haz the power, 2012-09-18 04:39:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thorogood@chromium.org/10915252/10001

[commit-bot: I haz the power, 2012-09-18 09:49:38]

Change committed as 157332