Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 10915252: Always include base extension type in Mac select file dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: openradar link Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/dialogs/select_file_dialog_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/file_system/file_system_api.cc
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc
index 68d306d75da0e39464318ab402ee6c735658dfd5..2c5c4762d9b501aa821d006ae85fd2309b32cbab 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.cc
+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc
@@ -192,16 +192,16 @@ bool GetFileTypesFromAcceptOption(
string16* description) {
std::set<FilePath::StringType> extension_set;
int description_id = 0;
- bool valid_type = false;
if (accept_option.mime_types.get()) {
std::vector<std::string>* list = accept_option.mime_types.get();
+ bool valid_type = false;
for (std::vector<std::string>::const_iterator iter = list->begin();
iter != list->end(); ++iter) {
std::vector<FilePath::StringType> inner;
std::string accept_type = *iter;
StringToLowerASCII(&accept_type);
- net::GetExtensionsForMimeType(*iter, &inner);
+ net::GetExtensionsForMimeType(accept_type, &inner);
if (inner.empty())
continue;
« no previous file with comments | « no previous file | ui/base/dialogs/select_file_dialog_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698