Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1091093006: Update {virtual,override} to follow C++11 style in content. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, je_julie(Not used), yusukes+watch_chromium.org, posciak+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, dgrogan, dmazzoni+watch_chromium.org, jdduke+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, aboxhall+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, dtseng+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, timvolodine, Michael van Ouwerkerk, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jsbell+idb_chromium.org, jochen+watch_chromium.org, plundblad+watch_chromium.org, riju_, mlamouri+watch-sensors_chromium.org, nektar+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in content. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/5120892497bc7707e492c045f1afebba3199a640 Cr-Commit-Position: refs/heads/master@{#326880}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Back out some webrtc files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -287 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/compositor/software_output_device_win.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/gamepad/raw_input_data_fetcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/indexed_db/mock_indexed_db_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/power_profiler/power_data_provider_ia_win.h View 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 4 chunks +9 lines, -10 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_truetype_font_win.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/system_message_window_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/time_zone_monitor_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_overscroll_animator_slider_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blink_platform_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M content/child/web_url_loader_impl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 5 chunks +21 lines, -21 lines 0 comments Download
M content/child/websocket_bridge.h View 1 chunk +13 lines, -14 lines 0 comments Download
M content/common/dwrite_font_platform_win.cc View 9 chunks +15 lines, -17 lines 0 comments Download
M content/common/font_cache_dispatcher_win.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/sandbox_mac_system_access_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/platform_event_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_download_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/mock_download_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/device_sensors/device_sensor_event_pump.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_center.h View 1 chunk +12 lines, -17 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_source.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webaudio_capturer_source.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/test/content_test_suite.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/ppapi/ppapi_test.h View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ncarter (slow)
Avi, please enjoy the bag of cotton candy that is this CL.
5 years, 8 months ago (2015-04-24 20:17:01 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-24 20:24:17 UTC) #3
cmumford
On 2015/04/24 at 20:24:17, avi wrote: > lgtm "git cl format" has some nice fixups ...
5 years, 8 months ago (2015-04-24 20:28:38 UTC) #4
ncarter (slow)
On 2015/04/24 20:28:38, cmumford wrote: > On 2015/04/24 at 20:24:17, avi wrote: > > lgtm ...
5 years, 8 months ago (2015-04-24 21:11:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091093006/40001
5 years, 8 months ago (2015-04-24 21:12:42 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 21:38:47 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:39:50 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5120892497bc7707e492c045f1afebba3199a640
Cr-Commit-Position: refs/heads/master@{#326880}

Powered by Google App Engine
This is Rietveld 408576698