Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: content/child/web_url_loader_impl_unittest.cc

Issue 1091093006: Update {virtual,override} to follow C++11 style in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back out some webrtc files. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/child/web_url_loader_impl.h ('k') | content/child/websocket_bridge.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 expect_multipart_response_(false), 108 expect_multipart_response_(false),
109 delete_on_receive_redirect_(false), 109 delete_on_receive_redirect_(false),
110 delete_on_receive_response_(false), 110 delete_on_receive_response_(false),
111 delete_on_receive_data_(false), 111 delete_on_receive_data_(false),
112 delete_on_finish_(false), 112 delete_on_finish_(false),
113 delete_on_fail_(false), 113 delete_on_fail_(false),
114 did_receive_redirect_(false), 114 did_receive_redirect_(false),
115 did_receive_response_(false), 115 did_receive_response_(false),
116 did_finish_(false) {} 116 did_finish_(false) {}
117 117
118 virtual ~TestWebURLLoaderClient() {} 118 ~TestWebURLLoaderClient() override {}
119 119
120 // blink::WebURLLoaderClient implementation: 120 // blink::WebURLLoaderClient implementation:
121 virtual void willSendRequest( 121 void willSendRequest(
122 blink::WebURLLoader* loader, 122 blink::WebURLLoader* loader,
123 blink::WebURLRequest& newRequest, 123 blink::WebURLRequest& newRequest,
124 const blink::WebURLResponse& redirectResponse) override { 124 const blink::WebURLResponse& redirectResponse) override {
125 EXPECT_TRUE(loader_); 125 EXPECT_TRUE(loader_);
126 EXPECT_EQ(loader_.get(), loader); 126 EXPECT_EQ(loader_.get(), loader);
127 // No test currently simulates mutiple redirects. 127 // No test currently simulates mutiple redirects.
128 EXPECT_FALSE(did_receive_redirect_); 128 EXPECT_FALSE(did_receive_redirect_);
129 did_receive_redirect_ = true; 129 did_receive_redirect_ = true;
130 130
131 if (delete_on_receive_redirect_) 131 if (delete_on_receive_redirect_)
132 loader_.reset(); 132 loader_.reset();
133 } 133 }
134 134
135 virtual void didSendData(blink::WebURLLoader* loader, 135 void didSendData(blink::WebURLLoader* loader,
136 unsigned long long bytesSent, 136 unsigned long long bytesSent,
137 unsigned long long totalBytesToBeSent) override { 137 unsigned long long totalBytesToBeSent) override {
138 EXPECT_TRUE(loader_); 138 EXPECT_TRUE(loader_);
139 EXPECT_EQ(loader_.get(), loader); 139 EXPECT_EQ(loader_.get(), loader);
140 } 140 }
141 141
142 virtual void didReceiveResponse( 142 void didReceiveResponse(
143 blink::WebURLLoader* loader, 143 blink::WebURLLoader* loader,
144 const blink::WebURLResponse& response) override { 144 const blink::WebURLResponse& response) override {
145 EXPECT_TRUE(loader_); 145 EXPECT_TRUE(loader_);
146 EXPECT_EQ(loader_.get(), loader); 146 EXPECT_EQ(loader_.get(), loader);
147 147
148 // Only multipart requests may receive multiple response headers. 148 // Only multipart requests may receive multiple response headers.
149 EXPECT_TRUE(expect_multipart_response_ || !did_receive_response_); 149 EXPECT_TRUE(expect_multipart_response_ || !did_receive_response_);
150 150
151 did_receive_response_ = true; 151 did_receive_response_ = true;
152 response_ = response; 152 response_ = response;
153 if (delete_on_receive_response_) 153 if (delete_on_receive_response_)
154 loader_.reset(); 154 loader_.reset();
155 } 155 }
156 156
157 virtual void didDownloadData(blink::WebURLLoader* loader, 157 void didDownloadData(blink::WebURLLoader* loader,
158 int dataLength, 158 int dataLength,
159 int encodedDataLength) override { 159 int encodedDataLength) override {
160 EXPECT_TRUE(loader_); 160 EXPECT_TRUE(loader_);
161 EXPECT_EQ(loader_.get(), loader); 161 EXPECT_EQ(loader_.get(), loader);
162 } 162 }
163 163
164 virtual void didReceiveData(blink::WebURLLoader* loader, 164 void didReceiveData(blink::WebURLLoader* loader,
165 const char* data, 165 const char* data,
166 int dataLength, 166 int dataLength,
167 int encodedDataLength) override { 167 int encodedDataLength) override {
168 EXPECT_TRUE(loader_); 168 EXPECT_TRUE(loader_);
169 EXPECT_EQ(loader_.get(), loader); 169 EXPECT_EQ(loader_.get(), loader);
170 // The response should have started, but must not have finished, or failed. 170 // The response should have started, but must not have finished, or failed.
171 EXPECT_TRUE(did_receive_response_); 171 EXPECT_TRUE(did_receive_response_);
172 EXPECT_FALSE(did_finish_); 172 EXPECT_FALSE(did_finish_);
173 EXPECT_EQ(net::OK, error_.reason); 173 EXPECT_EQ(net::OK, error_.reason);
174 EXPECT_EQ("", error_.domain.utf8()); 174 EXPECT_EQ("", error_.domain.utf8());
175 175
176 received_data_.append(data, dataLength); 176 received_data_.append(data, dataLength);
177 177
178 if (delete_on_receive_data_) 178 if (delete_on_receive_data_)
179 loader_.reset(); 179 loader_.reset();
180 } 180 }
181 181
182 virtual void didReceiveCachedMetadata(blink::WebURLLoader* loader, 182 void didReceiveCachedMetadata(blink::WebURLLoader* loader,
183 const char* data, 183 const char* data,
184 int dataLength) override { 184 int dataLength) override {
185 EXPECT_EQ(loader_.get(), loader); 185 EXPECT_EQ(loader_.get(), loader);
186 } 186 }
187 187
188 virtual void didFinishLoading(blink::WebURLLoader* loader, 188 void didFinishLoading(blink::WebURLLoader* loader,
189 double finishTime, 189 double finishTime,
190 int64_t totalEncodedDataLength) override { 190 int64_t totalEncodedDataLength) override {
191 EXPECT_TRUE(loader_); 191 EXPECT_TRUE(loader_);
192 EXPECT_EQ(loader_.get(), loader); 192 EXPECT_EQ(loader_.get(), loader);
193 EXPECT_TRUE(did_receive_response_); 193 EXPECT_TRUE(did_receive_response_);
194 EXPECT_FALSE(did_finish_); 194 EXPECT_FALSE(did_finish_);
195 did_finish_ = true; 195 did_finish_ = true;
196 196
197 if (delete_on_finish_) 197 if (delete_on_finish_)
198 loader_.reset(); 198 loader_.reset();
199 } 199 }
200 200
201 virtual void didFail(blink::WebURLLoader* loader, 201 void didFail(blink::WebURLLoader* loader,
202 const blink::WebURLError& error) override { 202 const blink::WebURLError& error) override {
203 EXPECT_TRUE(loader_); 203 EXPECT_TRUE(loader_);
204 EXPECT_EQ(loader_.get(), loader); 204 EXPECT_EQ(loader_.get(), loader);
205 EXPECT_FALSE(did_finish_); 205 EXPECT_FALSE(did_finish_);
206 error_ = error; 206 error_ = error;
207 207
208 if (delete_on_fail_) 208 if (delete_on_fail_)
209 loader_.reset(); 209 loader_.reset();
210 } 210 }
211 211
212 WebURLLoaderImpl* loader() { return loader_.get(); } 212 WebURLLoaderImpl* loader() { return loader_.get(); }
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 EXPECT_EQ(kMimeType, client()->response().mimeType().latin1()); 679 EXPECT_EQ(kMimeType, client()->response().mimeType().latin1());
680 680
681 DoReceiveData(); 681 DoReceiveData();
682 DoCompleteRequest(); 682 DoCompleteRequest();
683 EXPECT_FALSE(dispatcher()->canceled()); 683 EXPECT_FALSE(dispatcher()->canceled());
684 EXPECT_EQ(kTestData, client()->received_data()); 684 EXPECT_EQ(kTestData, client()->received_data());
685 } 685 }
686 686
687 } // namespace 687 } // namespace
688 } // namespace content 688 } // namespace content
OLDNEW
« no previous file with comments | « content/child/web_url_loader_impl.h ('k') | content/child/websocket_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698