Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 1091093006: Update {virtual,override} to follow C++11 style in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back out some webrtc files. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_url_loader_impl.h ('k') | content/child/websocket_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index f1321696708ff30f233f4ddf64bac09fc0cd8521..7a48565e315a99ad313fcb7fa33469c099d0e2cd 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -115,10 +115,10 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
did_receive_response_(false),
did_finish_(false) {}
- virtual ~TestWebURLLoaderClient() {}
+ ~TestWebURLLoaderClient() override {}
// blink::WebURLLoaderClient implementation:
- virtual void willSendRequest(
+ void willSendRequest(
blink::WebURLLoader* loader,
blink::WebURLRequest& newRequest,
const blink::WebURLResponse& redirectResponse) override {
@@ -132,14 +132,14 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
loader_.reset();
}
- virtual void didSendData(blink::WebURLLoader* loader,
- unsigned long long bytesSent,
- unsigned long long totalBytesToBeSent) override {
+ void didSendData(blink::WebURLLoader* loader,
+ unsigned long long bytesSent,
+ unsigned long long totalBytesToBeSent) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
}
- virtual void didReceiveResponse(
+ void didReceiveResponse(
blink::WebURLLoader* loader,
const blink::WebURLResponse& response) override {
EXPECT_TRUE(loader_);
@@ -154,17 +154,17 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
loader_.reset();
}
- virtual void didDownloadData(blink::WebURLLoader* loader,
- int dataLength,
- int encodedDataLength) override {
+ void didDownloadData(blink::WebURLLoader* loader,
+ int dataLength,
+ int encodedDataLength) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
}
- virtual void didReceiveData(blink::WebURLLoader* loader,
- const char* data,
- int dataLength,
- int encodedDataLength) override {
+ void didReceiveData(blink::WebURLLoader* loader,
+ const char* data,
+ int dataLength,
+ int encodedDataLength) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
// The response should have started, but must not have finished, or failed.
@@ -179,15 +179,15 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
loader_.reset();
}
- virtual void didReceiveCachedMetadata(blink::WebURLLoader* loader,
- const char* data,
- int dataLength) override {
+ void didReceiveCachedMetadata(blink::WebURLLoader* loader,
+ const char* data,
+ int dataLength) override {
EXPECT_EQ(loader_.get(), loader);
}
- virtual void didFinishLoading(blink::WebURLLoader* loader,
- double finishTime,
- int64_t totalEncodedDataLength) override {
+ void didFinishLoading(blink::WebURLLoader* loader,
+ double finishTime,
+ int64_t totalEncodedDataLength) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
EXPECT_TRUE(did_receive_response_);
@@ -198,8 +198,8 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
loader_.reset();
}
- virtual void didFail(blink::WebURLLoader* loader,
- const blink::WebURLError& error) override {
+ void didFail(blink::WebURLLoader* loader,
+ const blink::WebURLError& error) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
EXPECT_FALSE(did_finish_);
« no previous file with comments | « content/child/web_url_loader_impl.h ('k') | content/child/websocket_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698