Issue 10909234: views: Delete painter pointer using scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909234: views: Delete painter pointer using scoped_ptr. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Delete painter pointer using scoped_ptr. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157362

Patch Set 2 : style clean ups #

Patch Set 3 : clean ups to border.h #

Total comments: 5

Patch Set 4 : fix nits #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -17 lines)			Patch
	M	ui/views/border.h	View	1 2 3	2 chunks	+7 lines, -3 lines	0 comments	Download
	M	ui/views/border.cc	View	1 2 3	5 chunks	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.h File ui/views/border.h (right): http://codereview.chromium.org/10909234/diff/8002/ui/views/border.h#newcode10 ui/views/border.h:10: #include "ui/gfx/insets.h" We can remove this include and view.h ...

8 years, 3 months ago (2012-09-14 14:54:49 UTC) #2

sky

8 years, 3 months ago (2012-09-17 14:10:27 UTC) #4

LGTM

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.cc
File ui/views/border.cc (right):

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.cc#newcode26
ui/views/border.cc:26: int top_;
const

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.cc#newcode36
ui/views/border.cc:36: SidedSolidBorder::SidedSolidBorder(int top, int left, int
bottom, int right,
each param on its own line.

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.cc#newcode141
ui/views/border.cc:141: Border* Border::CreateSolidSidedBorder(int top, int
left,
each param on its own line.

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.h
File ui/views/border.h (right):

http://codereview.chromium.org/10909234/diff/8002/ui/views/border.h#newcode54
ui/views/border.h:54: static Border* CreateSolidSidedBorder(int top, int left,
each param on its own line.