views: Delete painter pointer using scoped_ptr.

ui/views/border.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BORDER_H_
 #define UI_VIEWS_BORDER_H_
 
+#include "base/basictypes.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/insets.h"

[tfarina, 2012/09/14 14:54:49]

We can remove this include and view.h and just forward declare the types needed.
But I'll do it a follow up, because other files are relying on them and given me
too much errors to fix within this patch.

 #include "ui/views/view.h"
+#include "ui/views/views_export.h"
 
 namespace gfx{
 class Canvas;
 }
 
 namespace views {
 
 class Painter;
 class View;
 
@@ skipping 21 matching lines @@
   // Creates a border that is a simple line of the specified thickness and
   // color.
   static Border* CreateSolidBorder(int thickness, SkColor color);
 
   // Creates a border for reserving space. The returned border does not
   // paint anything.
   static Border* CreateEmptyBorder(int top, int left, int bottom, int right);
 
   // Creates a border of the specified color, and specified thickness on each
   // side.
   static Border* CreateSolidSidedBorder(int top, int left,

[sky, 2012/09/17 14:10:27]

each param on its own line.

-      int bottom, int right,
-      SkColor color);
+                                        int bottom, int right,
+                                        SkColor color);
 
   // Creates a Border from the specified Painter. The border owns the painter,
   // thus the painter is deleted when the Border is deleted.
   static Border* CreateBorderPainter(Painter* painter);
 
   // Renders the border for the specified view.
   virtual void Paint(const View& view, gfx::Canvas* canvas) const = 0;
 
   // Sets the specified insets to the the border insets.
   virtual void GetInsets(gfx::Insets* insets) const = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Border);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BORDER_H_