Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: ui/views/border.cc

Issue 10909234: views: Delete painter pointer using scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/border.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/border.cc
diff --git a/ui/views/border.cc b/ui/views/border.cc
index 1cfb037d0cece46b08cb0df13bb495d3cb8bdf35..064f04b48c6b4acf06e92e0fde8fa7926d089648 100644
--- a/ui/views/border.cc
+++ b/ui/views/border.cc
@@ -5,6 +5,7 @@
#include "ui/views/border.h"
#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
#include "ui/gfx/canvas.h"
#include "ui/views/painter.h"
@@ -22,15 +23,21 @@ class SidedSolidBorder : public Border {
virtual void GetInsets(gfx::Insets* insets) const OVERRIDE;
private:
- int top_, left_, bottom_, right_;
+ const int top_;
+ const int left_;
+ const int bottom_;
+ const int right_;
SkColor color_;
gfx::Insets insets_;
DISALLOW_COPY_AND_ASSIGN(SidedSolidBorder);
};
-SidedSolidBorder::SidedSolidBorder(int top, int left, int bottom, int right,
- SkColor color)
+SidedSolidBorder::SidedSolidBorder(int top,
+ int left,
+ int bottom,
+ int right,
+ SkColor color)
: top_(top),
left_(left),
bottom_(bottom),
@@ -97,14 +104,11 @@ class BorderPainter : public Border {
DCHECK(painter);
}
- virtual ~BorderPainter() {
- delete painter_;
- painter_ = NULL;
- }
+ virtual ~BorderPainter() {}
// Overridden from Border:
virtual void Paint(const View& view, gfx::Canvas* canvas) const OVERRIDE {
- Painter::PaintPainterAt(canvas, painter_, view.GetLocalBounds());
+ Painter::PaintPainterAt(canvas, painter_.get(), view.GetLocalBounds());
}
virtual void GetInsets(gfx::Insets* insets) const OVERRIDE {
@@ -113,12 +117,12 @@ class BorderPainter : public Border {
}
private:
- Painter* painter_;
+ scoped_ptr<Painter> painter_;
DISALLOW_COPY_AND_ASSIGN(BorderPainter);
};
-} // namespace
+} // namespace
Border::Border() {
}
@@ -137,13 +141,15 @@ Border* Border::CreateEmptyBorder(int top, int left, int bottom, int right) {
}
// static
-Border* Border::CreateSolidSidedBorder(int top, int left,
- int bottom, int right,
- SkColor color) {
+Border* Border::CreateSolidSidedBorder(int top,
+ int left,
+ int bottom,
+ int right,
+ SkColor color) {
return new SidedSolidBorder(top, left, bottom, right, color);
}
-//static
+// static
Border* Border::CreateBorderPainter(Painter* painter) {
return new BorderPainter(painter);
}
« no previous file with comments | « ui/views/border.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698