Issue 3553. Stop treating static final variables as constants

Issue 3553. Stop treating static final variables as constants
http://code.google.com/p/dart/issues/detail?id=3553
http://code.google.com/p/dart/issues/detail?id=3476


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12336

[Brian Wilkerson, 2012-09-13 15:20:58]

LGTM once the comments related to the tests are addressed

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
File
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java
(right):

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:19:
* We should understand "const" keyword and temporary treat both "const" and
"const" as
Does this test even make sense any more? (The comment certainly doesn't.)

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:32:
" const SF1 = CT + 1;",
If we keep the test, these two lines can be removed because they duplicate the
two lines above.

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:316:
"  const INT_LIT = 5;",
I understand why you replaced 'final' with 'const' above, but 'static const'
still makes sense, so I'm not sure why you deleted the 'static' modifier in this
and following tests.

[scheglov, 2012-09-13 15:38:45]

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
File
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java
(right):

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:19:
* We should understand "const" keyword and temporary treat both "const" and
"const" as
On 2012/09/13 15:20:58, Brian Wilkerson wrote:
> Does this test even make sense any more? (The comment certainly doesn't.)

Yes, we don't need this test anymore.

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:32:
" const SF1 = CT + 1;",
On 2012/09/13 15:20:58, Brian Wilkerson wrote:
> If we keep the test, these two lines can be removed because they duplicate the
> two lines above.

Test was removed.

https://codereview.chromium.org/10907215/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:316:
"  const INT_LIT = 5;",
On 2012/09/13 15:20:58, Brian Wilkerson wrote:
> I understand why you replaced 'final' with 'const' above, but 'static const'
> still makes sense, so I'm not sure why you deleted the 'static' modifier in
this
> and following tests.

"static const" makes sense, but not as the main characteristic of the "const".
It may be interesting to have some tests with "static" and some without.
Now we will keep "static const" where field is named in all upper-case letters
and just "const" in other places.

[Brian Wilkerson, 2012-09-13 15:42:56]

LGTM