Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10907215: Issue 3553. Stop treating static final variables as constants (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweaks for tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java ('k') | compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index f5f255e8c3c594b00dc8e5e6c93ef213dfaa0d37..562d43a5b170365fc22c2eefe7d7169686ec18dc 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -357,6 +357,7 @@ public class Resolver {
FieldElement fieldElement = node.getElement();
if (fieldElement != null && fieldElement.getModifiers().isFinal()
&& !fieldElement.isStatic()
+ && !fieldElement.getModifiers().isConstant()
&& !fieldElement.getModifiers().isGetter()
&& !fieldElement.getModifiers().isSetter()
&& !fieldElement.getModifiers().isInitialized()) {
« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java ('k') | compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698