compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java - Issue 10907215: Issue 3553. Stop treating static final variables as constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

Issue 10907215: Issue 3553. Stop treating static final variables as constants (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweaks for tests Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

index 19c06f3bbc387e4ce88a4f0ead23a4d31d94bc12..fa16775977e64ef93b2f98b2b4d729f015dbcbb8 100644

--- a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

@@ -385,9 +385,7 @@ public class CompileTimeConstantAnalyzer {

visitedElements.add(element);

// Should be declared as constant.

- // TODO(brianwilkerson) Remove the second condition when final variables are no longer

- // treated like constants

- if (!element.getModifiers().isConstant() && !element.getModifiers().isFinal()) {

+ if (!element.getModifiers().isConstant()) {

expectedConstant(x);

}

« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/Elements.java » ('j') | no next file with comments »