Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090573002: Revert of Revert of DevTools: allow storing devtools preferences on the browser side. [blink] (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of DevTools: allow storing devtools preferences on the browser side. [blink] (patchset #1 id:1 of https://codereview.chromium.org/1088093002/) Reason for revert: You reverted it over a broken test failure. Make sure you look at the flakiness dashboard prior to revering things: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=http/tests/inspector/service-workers/service-workers-redundant.html Original issue's description: > Revert of DevTools: allow storing devtools preferences on the browser side. [blink] (patchset #6 id:100001 of https://codereview.chromium.org/1066813003/) > > Reason for revert: > This seems to have badly broken http/tests/inspector/service-workers/service-workers-redundant.html > > See: > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20(dbg)/builds/535 > > BUG=472488 > > Original issue's description: > > DevTools: allow storing devtools preferences on the browser side. [blink] > > > > BUG=376788 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193715 > > TBR=dgozman@chromium.org,pfeldman@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=376788 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193772 TBR=dgozman@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -179 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/split-view.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/split-view-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/devtools/front_end/bindings/BreakpointManager.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/common/Settings.js View 14 chunks +141 lines, -132 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js View 1 chunk +36 lines, -0 lines 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHost.js View 2 chunks +57 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 2 chunks +55 lines, -13 lines 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/TabbedEditorContainer.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SplitView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/ExcludedFolderManager.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/FileManager.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/FileSystemMapping.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
pfeldman
Created Revert of Revert of DevTools: allow storing devtools preferences on the browser side. [blink]
5 years, 8 months ago (2015-04-15 10:03:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090573002/1
5 years, 8 months ago (2015-04-15 10:03:26 UTC) #2
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-16 09:38:33 UTC) #5 
On 2015/04/15 at 10:03:26, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1090573002/1

That never landed. Should it be closed?

Powered by Google App Engine
This is Rietveld 408576698