Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1066813003: DevTools: allow storing devtools preferences on the browser side. [blink] (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: allow storing devtools preferences on the browser side. [blink] BUG=376788 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193715

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : review comments addressed #

Patch Set 5 : #

Patch Set 6 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -176 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/split-view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/split-view-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M Source/devtools/front_end/bindings/BreakpointManager.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 2 3 14 chunks +140 lines, -131 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/devtools_app/InspectorFrontendHostImpl.js View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHost.js View 1 2 3 2 chunks +57 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 4 2 chunks +53 lines, -11 lines 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sources/AdvancedSearchView.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SplitView.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/ExcludedFolderManager.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/FileManager.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/FileSystemMapping.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
pfeldman
PTAL
5 years, 8 months ago (2015-04-13 13:12:53 UTC) #2
dgozman
https://codereview.chromium.org/1066813003/diff/40001/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (right): https://codereview.chromium.org/1066813003/diff/40001/Source/devtools/front_end/common/Settings.js#newcode514 Source/devtools/front_end/common/Settings.js:514: // This one is localStorage secific, which is fine. ...
5 years, 8 months ago (2015-04-13 14:25:38 UTC) #3
pfeldman
https://codereview.chromium.org/1066813003/diff/40001/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (right): https://codereview.chromium.org/1066813003/diff/40001/Source/devtools/front_end/common/Settings.js#newcode514 Source/devtools/front_end/common/Settings.js:514: // This one is localStorage secific, which is fine. ...
5 years, 8 months ago (2015-04-13 16:03:38 UTC) #4
dgozman
lgtm
5 years, 8 months ago (2015-04-13 16:30:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066813003/80001
5 years, 8 months ago (2015-04-14 10:21:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/59105)
5 years, 8 months ago (2015-04-14 13:52:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066813003/100001
5 years, 8 months ago (2015-04-14 15:20:54 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193715
5 years, 8 months ago (2015-04-14 16:52:08 UTC) #13
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-15 09:58:25 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1088093002/ by mlamouri@chromium.org.

The reason for reverting is: This seems to have badly broken
http/tests/inspector/service-workers/service-workers-redundant.html

See:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%...

BUG=472488.

Powered by Google App Engine
This is Rietveld 408576698