Source/devtools/front_end/sources/TabbedEditorContainer.js - Issue 1090573002: Revert of Revert of DevTools: allow storing devtools preferences on the browser side. [blink]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 1090573002: Revert of Revert of DevTools: allow storing devtools preferences on the browser side. [blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/sources/SourcesView.js ('k') | Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sources/TabbedEditorContainer.js

diff --git a/Source/devtools/front_end/sources/TabbedEditorContainer.js b/Source/devtools/front_end/sources/TabbedEditorContainer.js

index a06be051b01d9871c02756e112457b228e0053e1..85c2deb2872e8a3337326c0b11c19da5c5b5b868 100644

--- a/Source/devtools/front_end/sources/TabbedEditorContainer.js

+++ b/Source/devtools/front_end/sources/TabbedEditorContainer.js

@@ -43,10 +43,10 @@

* @constructor

* @extends {WebInspector.Object}

* @param {!WebInspector.TabbedEditorContainerDelegate} delegate

- * @param {string} settingName

+ * @param {!WebInspector.Setting} setting

* @param {string} placeholderText

-WebInspector.TabbedEditorContainer = function(delegate, settingName, placeholderText)

+WebInspector.TabbedEditorContainer = function(delegate, setting, placeholderText)

{

WebInspector.Object.call(this);

this._delegate = delegate;

@@ -64,7 +64,7 @@

this._tabIds = new Map();

this._files = {};

- this._previouslyViewedFilesSetting = WebInspector.settings.createSetting(settingName, []);

+ this._previouslyViewedFilesSetting = setting;

this._history = WebInspector.TabbedEditorContainer.History.fromObject(this._previouslyViewedFilesSetting.get());

}