[release-tools] Chrome V8 version is now converted to real V8 version

Chrome V8 version is now converted to real V8 version

BUG=
NOTRY=true

[Michael Hablich, 2015-04-17 10:55:05]

hablich@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Hablich, 2015-04-17 10:55:13]

On 2015/04/17 10:55:05, Hablich wrote:
> mailto:hablich@chromium.org changed reviewers:
> + mailto:machenbach@chromium.org

PTAL

[Michael Achenbach, 2015-04-17 13:23:09]

Not sure if we should use the shortened versions on that dashboard. If you want
to create a link to a webpage that requires the long version, then you need to
extend it again.

Or just shorten in the appscript on the dashboard where needed.

https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py#n...
tools/release/releases.py:464: if v8_version.split(".")[3]== "0":
nit: space before ==

[Michael Hablich, 2015-04-20 07:05:28]

On 2015/04/17 13:23:09, Michael Achenbach wrote:
> Not sure if we should use the shortened versions on that dashboard. If you
want
> to create a link to a webpage that requires the long version, then you need to
> extend it again.
> 
> Or just shorten in the appscript on the dashboard where needed.
> 
> https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py
> File tools/release/releases.py (right):
> 
>
https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py#n...
> tools/release/releases.py:464: if v8_version.split(".")[3]== "0":
> nit: space before ==

I want to sanitize the data at one point. As the Python script is the data
provider and does it already and says it provides a v8_version it makes sense
that it is done in the Python script. I would like to put only display logic
into the AppScript.

[Michael Hablich, 2015-04-20 12:29:01]

On 2015/04/20 07:05:28, Hablich wrote:
> On 2015/04/17 13:23:09, Michael Achenbach wrote:
> > Not sure if we should use the shortened versions on that dashboard. If you
> want
> > to create a link to a webpage that requires the long version, then you need
to
> > extend it again.
> > 
> > Or just shorten in the appscript on the dashboard where needed.
> > 
> > https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py
> > File tools/release/releases.py (right):
> > 
> >
>
https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py#n...
> > tools/release/releases.py:464: if v8_version.split(".")[3]== "0":
> > nit: space before ==
> 
> I want to sanitize the data at one point. As the Python script is the data
> provider and does it already and says it provides a v8_version it makes sense
> that it is done in the Python script. I would like to put only display logic
> into the AppScript.

The upload tool merged other changes into this cl. Sorry, you can ignore PS 2.

[Michael Hablich, 2015-04-20 12:29:17]

Patchset #2 (id:20001) has been deleted

[Michael Hablich, 2015-04-20 12:29:34]

https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py#n...
tools/release/releases.py:464: if v8_version.split(".")[3]== "0":
On 2015/04/17 13:23:09, Michael Achenbach wrote:
> nit: space before ==

Acknowledged.

[Michael Achenbach, 2015-04-27 13:12:14]

Is this waiting for any action from me? Did you upload a new patch set or is the
CL outdated?

[Michael Hablich, 2015-04-27 13:43:31]

On 2015/04/27 13:12:14, Michael Achenbach wrote:
> Is this waiting for any action from me? Did you upload a new patch set or is
the
> CL outdated?

PTAL

[Michael Achenbach, 2015-04-28 20:48:49]

https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py#n...
tools/release/releases.py:464: if v8_version.split(".")[3]== "0":
On 2015/04/20 12:29:34, Hablich wrote:
> On 2015/04/17 13:23:09, Michael Achenbach wrote:
> > nit: space before ==
> 
> Acknowledged.

Acknowledged but not resolved?

https://codereview.chromium.org/1090183002/diff/60001/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1090183002/diff/60001/tools/release/releases....
tools/release/releases.py:480:
self._ConvertToRealV8Version(json.loads(result_raw)["v8_version"]))
nit: 4 spaces after round parenthesis or better:
previous_v8_version = self._ConvertToRealV8Version(
    json.loads(result_raw)["v8_version"])