tools/release/test_scripts.py - Issue 1090183002: [release-tools] Chrome V8 version is now converted to real V8 version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/release/test_scripts.py

Issue 1090183002: [release-tools] Chrome V8 version is now converted to real V8 version (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Swapped ' with " Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/release/test_scripts.py

diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py

index dc6f097384bfb0cf3d3816f17b202a53b1db63ac..98c6bb0f8a79cdacd650c241387dd4a4f8f2d769 100644

--- a/tools/release/test_scripts.py

+++ b/tools/release/test_scripts.py

@@ -1454,15 +1454,14 @@ Cr-Commit-Position: refs/heads/4.2.71@{#1}

self.assertEquals(csv, FileToText(csv_output))

expected_json = {"chrome_releases":{

- "canaries": [

- {

- "chrome_version": "2.2.2.2",

- "os": "win",

- "release_date": "04/09/15",

- "v8_version": "22.2.2.2",

- "v8_version_hash": "v8_version_hash",

- "v8_previous_version": "11.1.1.0",

- "v8_previous_version_hash": "v8_previous_version_hash"

+ "canaries": [{

+ "chrome_version": "2.2.2.2",

+ "os": "win",

+ "release_date": "04/09/15",

+ "v8_version": "22.2.2.2",

+ "v8_version_hash": "v8_version_hash",

+ "v8_previous_version": "11.1.1",

+ "v8_previous_version_hash": "v8_previous_version_hash"

}]},

"releases":[

{

« tools/release/releases.py ('K') | « tools/release/releases.py ('k') | no next file » | no next file with comments »