Issue 109013006: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109013006: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed)

Created:
6 years, 12 months ago by Avi (use Gerrit)

Modified:
6 years, 12 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, extensions-reviews_chromium.org, dyu1, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, browser-components-watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, benquan, robertshield, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dane Wallinga

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update some uses of UTF conversions in chrome/browser to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242447

Patch Set 1 #

Patch Set 2 : fix #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+293 lines, -240 lines)			Patch
M	chrome/browser/about_flags_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/accessibility/accessibility_extension_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc	View		8 chunks	+22 lines, -22 lines	0 comments	Download
M	chrome/browser/android/dev_tools_server.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/provider/chrome_browser_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/apps/app_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/apps/app_url_redirector_browsertest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/apps/shortcut_manager.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/apps/web_view_browsertest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/apps/web_view_interactive_browsertest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_browsertest.cc	View		11 chunks	+38 lines, -29 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input.cc	View		8 chunks	+15 lines, -13 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input_unittest.cc	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.cc	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider_unittest.cc	View		13 chunks	+32 lines, -31 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_result.cc	View		1 chunk	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_result_unittest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/bookmark_provider_unittest.cc	View		6 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/builtin_provider.cc	View		3 chunks	+20 lines, -18 lines	0 comments	Download
M	chrome/browser/autocomplete/builtin_provider_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/contact_provider_chromeos.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/autocomplete/contact_provider_chromeos_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider_unittest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View		6 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider_unittest.cc	View		9 chunks	+21 lines, -14 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/url_prefix.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/zero_suggest_provider.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_browsertest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_interactive_uitest.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/form_structure_browsertest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1	8 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/background/background_application_list_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

6 years, 12 months ago (2013-12-24 17:59:08 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r242447 (presubmit successful).

Expand Messages | Collapse Messages