chrome/browser/autocomplete/keyword_provider.cc - Issue 109013006: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/keyword_provider.cc

Issue 109013006: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_url_provider_unittest.cc ('k') | chrome/browser/autocomplete/keyword_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/keyword_provider.cc

diff --git a/chrome/browser/autocomplete/keyword_provider.cc b/chrome/browser/autocomplete/keyword_provider.cc

index a0e7d5f853df3cedae76084fbb960a8d2fc7c612..81a9012cc2be84804552e41edfe94889d895e2ef 100644

--- a/chrome/browser/autocomplete/keyword_provider.cc

+++ b/chrome/browser/autocomplete/keyword_provider.cc

@@ -362,7 +362,7 @@ void KeywordProvider::Start(const AutocompleteInput& input,

bool have_listeners =

extensions::ExtensionOmniboxEventRouter::OnInputChanged(

profile_, template_url->GetExtensionId(),

- UTF16ToUTF8(remaining_input), current_input_id_);

+ base::UTF16ToUTF8(remaining_input), current_input_id_);

// We only have to wait for suggest results if there are actually

// extensions listening for input changes.

@@ -590,10 +590,11 @@ void KeywordProvider::Observe(int type,

// interaction.

extension_suggest_matches_.push_back(CreateAutocompleteMatch(

template_url, input, keyword.length(),

- UTF8ToUTF16(suggestion.content), false, first_relevance - (i + 1)));

+ base::UTF8ToUTF16(suggestion.content), false,

+ first_relevance - (i + 1)));

AutocompleteMatch* match = &extension_suggest_matches_.back();

- match->contents.assign(UTF8ToUTF16(suggestion.description));

+ match->contents.assign(base::UTF8ToUTF16(suggestion.description));

match->contents_class =

extensions::StyleTypesToACMatchClassifications(suggestion);

match->description.clear();