Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc

Issue 109013006: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 } 142 }
143 143
144 TEST_F(PartnerBookmarksShimTest, RemoveBookmarks) { 144 TEST_F(PartnerBookmarksShimTest, RemoveBookmarks) {
145 PartnerBookmarksShim* shim = partner_bookmarks_shim(); 145 PartnerBookmarksShim* shim = partner_bookmarks_shim();
146 shim->AddObserver(&observer_); 146 shim->AddObserver(&observer_);
147 147
148 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0); 148 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
149 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0); 149 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
150 150
151 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0); 151 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
152 root_partner_node->SetTitle(ASCIIToUTF16("Partner bookmarks")); 152 root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
153 153
154 BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://www.a.net")); 154 BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://www.a.net"));
155 partner_folder1->set_type(BookmarkNode::FOLDER); 155 partner_folder1->set_type(BookmarkNode::FOLDER);
156 root_partner_node->Add(partner_folder1, root_partner_node->child_count()); 156 root_partner_node->Add(partner_folder1, root_partner_node->child_count());
157 157
158 BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL("http://www.b.net")); 158 BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL("http://www.b.net"));
159 partner_folder2->set_type(BookmarkNode::FOLDER); 159 partner_folder2->set_type(BookmarkNode::FOLDER);
160 root_partner_node->Add(partner_folder2, root_partner_node->child_count()); 160 root_partner_node->Add(partner_folder2, root_partner_node->child_count());
161 161
162 BookmarkNode* partner_bookmark1 = new BookmarkNode(3, 162 BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 } 231 }
232 232
233 TEST_F(PartnerBookmarksShimTest, RenameBookmarks) { 233 TEST_F(PartnerBookmarksShimTest, RenameBookmarks) {
234 PartnerBookmarksShim* shim = partner_bookmarks_shim(); 234 PartnerBookmarksShim* shim = partner_bookmarks_shim();
235 shim->AddObserver(&observer_); 235 shim->AddObserver(&observer_);
236 236
237 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0); 237 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
238 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0); 238 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
239 239
240 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0); 240 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
241 root_partner_node->SetTitle(ASCIIToUTF16("Partner bookmarks")); 241 root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
242 242
243 BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://www.a.net")); 243 BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://www.a.net"));
244 partner_folder1->set_type(BookmarkNode::FOLDER); 244 partner_folder1->set_type(BookmarkNode::FOLDER);
245 partner_folder1->SetTitle(ASCIIToUTF16("a.net")); 245 partner_folder1->SetTitle(base::ASCIIToUTF16("a.net"));
246 root_partner_node->Add(partner_folder1, root_partner_node->child_count()); 246 root_partner_node->Add(partner_folder1, root_partner_node->child_count());
247 247
248 BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL("http://www.b.net")); 248 BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL("http://www.b.net"));
249 partner_folder2->set_type(BookmarkNode::FOLDER); 249 partner_folder2->set_type(BookmarkNode::FOLDER);
250 partner_folder2->SetTitle(ASCIIToUTF16("b.net")); 250 partner_folder2->SetTitle(base::ASCIIToUTF16("b.net"));
251 root_partner_node->Add(partner_folder2, root_partner_node->child_count()); 251 root_partner_node->Add(partner_folder2, root_partner_node->child_count());
252 252
253 BookmarkNode* partner_bookmark1 = new BookmarkNode(3, 253 BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
254 GURL("http://www.a.com")); 254 GURL("http://www.a.com"));
255 partner_bookmark1->set_type(BookmarkNode::URL); 255 partner_bookmark1->set_type(BookmarkNode::URL);
256 partner_bookmark1->SetTitle(ASCIIToUTF16("a.com")); 256 partner_bookmark1->SetTitle(base::ASCIIToUTF16("a.com"));
257 partner_folder1->Add(partner_bookmark1, partner_folder1->child_count()); 257 partner_folder1->Add(partner_bookmark1, partner_folder1->child_count());
258 258
259 BookmarkNode* partner_bookmark2 = new BookmarkNode(4, 259 BookmarkNode* partner_bookmark2 = new BookmarkNode(4,
260 GURL("http://www.b.com")); 260 GURL("http://www.b.com"));
261 partner_bookmark2->set_type(BookmarkNode::URL); 261 partner_bookmark2->set_type(BookmarkNode::URL);
262 partner_bookmark2->SetTitle(ASCIIToUTF16("b.com")); 262 partner_bookmark2->SetTitle(base::ASCIIToUTF16("b.com"));
263 partner_folder2->Add(partner_bookmark2, partner_folder2->child_count()); 263 partner_folder2->Add(partner_bookmark2, partner_folder2->child_count());
264 264
265 ASSERT_FALSE(shim->IsLoaded()); 265 ASSERT_FALSE(shim->IsLoaded());
266 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1); 266 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
267 shim->SetPartnerBookmarksRoot(root_partner_node); 267 shim->SetPartnerBookmarksRoot(root_partner_node);
268 ASSERT_TRUE(shim->IsLoaded()); 268 ASSERT_TRUE(shim->IsLoaded());
269 269
270 EXPECT_EQ(root_partner_node, shim->GetNodeByID(0)); 270 EXPECT_EQ(root_partner_node, shim->GetNodeByID(0));
271 EXPECT_EQ(partner_folder1, shim->GetNodeByID(1)); 271 EXPECT_EQ(partner_folder1, shim->GetNodeByID(1));
272 EXPECT_EQ(partner_folder2, shim->GetNodeByID(2)); 272 EXPECT_EQ(partner_folder2, shim->GetNodeByID(2));
273 EXPECT_EQ(partner_bookmark1, shim->GetNodeByID(3)); 273 EXPECT_EQ(partner_bookmark1, shim->GetNodeByID(3));
274 EXPECT_EQ(partner_bookmark2, shim->GetNodeByID(4)); 274 EXPECT_EQ(partner_bookmark2, shim->GetNodeByID(4));
275 275
276 EXPECT_TRUE(shim->IsReachable(root_partner_node)); 276 EXPECT_TRUE(shim->IsReachable(root_partner_node));
277 EXPECT_TRUE(shim->IsReachable(partner_folder1)); 277 EXPECT_TRUE(shim->IsReachable(partner_folder1));
278 EXPECT_TRUE(shim->IsReachable(partner_folder2)); 278 EXPECT_TRUE(shim->IsReachable(partner_folder2));
279 EXPECT_TRUE(shim->IsReachable(partner_bookmark1)); 279 EXPECT_TRUE(shim->IsReachable(partner_bookmark1));
280 EXPECT_TRUE(shim->IsReachable(partner_bookmark2)); 280 EXPECT_TRUE(shim->IsReachable(partner_bookmark2));
281 281
282 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(1); 282 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(1);
283 EXPECT_EQ(ASCIIToUTF16("b.com"), shim->GetTitle(partner_bookmark2)); 283 EXPECT_EQ(base::ASCIIToUTF16("b.com"), shim->GetTitle(partner_bookmark2));
284 shim->RenameBookmark(partner_bookmark2, ASCIIToUTF16("b2.com")); 284 shim->RenameBookmark(partner_bookmark2, base::ASCIIToUTF16("b2.com"));
285 EXPECT_EQ(ASCIIToUTF16("b2.com"), shim->GetTitle(partner_bookmark2)); 285 EXPECT_EQ(base::ASCIIToUTF16("b2.com"), shim->GetTitle(partner_bookmark2));
286 286
287 EXPECT_TRUE(shim->IsReachable(root_partner_node)); 287 EXPECT_TRUE(shim->IsReachable(root_partner_node));
288 EXPECT_TRUE(shim->IsReachable(partner_folder1)); 288 EXPECT_TRUE(shim->IsReachable(partner_folder1));
289 EXPECT_TRUE(shim->IsReachable(partner_folder2)); 289 EXPECT_TRUE(shim->IsReachable(partner_folder2));
290 EXPECT_TRUE(shim->IsReachable(partner_bookmark1)); 290 EXPECT_TRUE(shim->IsReachable(partner_bookmark1));
291 EXPECT_TRUE(shim->IsReachable(partner_bookmark2)); 291 EXPECT_TRUE(shim->IsReachable(partner_bookmark2));
292 292
293 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(1); 293 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(1);
294 EXPECT_EQ(ASCIIToUTF16("a.net"), shim->GetTitle(partner_folder1)); 294 EXPECT_EQ(base::ASCIIToUTF16("a.net"), shim->GetTitle(partner_folder1));
295 shim->RenameBookmark(partner_folder1, ASCIIToUTF16("a2.net")); 295 shim->RenameBookmark(partner_folder1, base::ASCIIToUTF16("a2.net"));
296 EXPECT_EQ(ASCIIToUTF16("a2.net"), shim->GetTitle(partner_folder1)); 296 EXPECT_EQ(base::ASCIIToUTF16("a2.net"), shim->GetTitle(partner_folder1));
297 297
298 EXPECT_TRUE(shim->IsReachable(root_partner_node)); 298 EXPECT_TRUE(shim->IsReachable(root_partner_node));
299 EXPECT_TRUE(shim->IsReachable(partner_folder1)); 299 EXPECT_TRUE(shim->IsReachable(partner_folder1));
300 EXPECT_TRUE(shim->IsReachable(partner_folder2)); 300 EXPECT_TRUE(shim->IsReachable(partner_folder2));
301 EXPECT_TRUE(shim->IsReachable(partner_bookmark1)); 301 EXPECT_TRUE(shim->IsReachable(partner_bookmark1));
302 EXPECT_TRUE(shim->IsReachable(partner_bookmark2)); 302 EXPECT_TRUE(shim->IsReachable(partner_bookmark2));
303 303
304 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(1); 304 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(1);
305 EXPECT_EQ(ASCIIToUTF16("Partner bookmarks"), 305 EXPECT_EQ(base::ASCIIToUTF16("Partner bookmarks"),
306 shim->GetTitle(root_partner_node)); 306 shim->GetTitle(root_partner_node));
307 shim->RenameBookmark(root_partner_node, ASCIIToUTF16("Partner")); 307 shim->RenameBookmark(root_partner_node, base::ASCIIToUTF16("Partner"));
308 EXPECT_EQ(ASCIIToUTF16("Partner"), shim->GetTitle(root_partner_node)); 308 EXPECT_EQ(base::ASCIIToUTF16("Partner"), shim->GetTitle(root_partner_node));
309 309
310 EXPECT_TRUE(shim->IsReachable(root_partner_node)); 310 EXPECT_TRUE(shim->IsReachable(root_partner_node));
311 EXPECT_TRUE(shim->IsReachable(partner_folder1)); 311 EXPECT_TRUE(shim->IsReachable(partner_folder1));
312 EXPECT_TRUE(shim->IsReachable(partner_folder2)); 312 EXPECT_TRUE(shim->IsReachable(partner_folder2));
313 EXPECT_TRUE(shim->IsReachable(partner_bookmark1)); 313 EXPECT_TRUE(shim->IsReachable(partner_bookmark1));
314 EXPECT_TRUE(shim->IsReachable(partner_bookmark2)); 314 EXPECT_TRUE(shim->IsReachable(partner_bookmark2));
315 } 315 }
316 316
317 TEST_F(PartnerBookmarksShimTest, SaveLoadProfile) { 317 TEST_F(PartnerBookmarksShimTest, SaveLoadProfile) {
318 { 318 {
319 PartnerBookmarksShim* shim = partner_bookmarks_shim(); 319 PartnerBookmarksShim* shim = partner_bookmarks_shim();
320 shim->AddObserver(&observer_); 320 shim->AddObserver(&observer_);
321 321
322 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0); 322 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
323 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0); 323 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
324 324
325 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0); 325 BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
326 root_partner_node->SetTitle(ASCIIToUTF16("Partner bookmarks")); 326 root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
327 327
328 BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://a.net")); 328 BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://a.net"));
329 partner_folder1->set_type(BookmarkNode::FOLDER); 329 partner_folder1->set_type(BookmarkNode::FOLDER);
330 partner_folder1->SetTitle(ASCIIToUTF16("a.net")); 330 partner_folder1->SetTitle(base::ASCIIToUTF16("a.net"));
331 root_partner_node->Add(partner_folder1, root_partner_node->child_count()); 331 root_partner_node->Add(partner_folder1, root_partner_node->child_count());
332 332
333 BookmarkNode* partner_bookmark1 = new BookmarkNode(3, 333 BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
334 GURL("http://a.com")); 334 GURL("http://a.com"));
335 partner_bookmark1->set_type(BookmarkNode::URL); 335 partner_bookmark1->set_type(BookmarkNode::URL);
336 partner_bookmark1->SetTitle(ASCIIToUTF16("a.com")); 336 partner_bookmark1->SetTitle(base::ASCIIToUTF16("a.com"));
337 partner_folder1->Add(partner_bookmark1, partner_folder1->child_count()); 337 partner_folder1->Add(partner_bookmark1, partner_folder1->child_count());
338 338
339 BookmarkNode* partner_bookmark2 = new BookmarkNode(5, 339 BookmarkNode* partner_bookmark2 = new BookmarkNode(5,
340 GURL("http://b.com")); 340 GURL("http://b.com"));
341 partner_bookmark2->set_type(BookmarkNode::URL); 341 partner_bookmark2->set_type(BookmarkNode::URL);
342 partner_bookmark2->SetTitle(ASCIIToUTF16("b.com")); 342 partner_bookmark2->SetTitle(base::ASCIIToUTF16("b.com"));
343 partner_folder1->Add(partner_bookmark2, partner_folder1->child_count()); 343 partner_folder1->Add(partner_bookmark2, partner_folder1->child_count());
344 344
345 ASSERT_FALSE(shim->IsLoaded()); 345 ASSERT_FALSE(shim->IsLoaded());
346 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1); 346 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
347 shim->SetPartnerBookmarksRoot(root_partner_node); 347 shim->SetPartnerBookmarksRoot(root_partner_node);
348 ASSERT_TRUE(shim->IsLoaded()); 348 ASSERT_TRUE(shim->IsLoaded());
349 349
350 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(2); 350 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(2);
351 shim->RenameBookmark(partner_bookmark1, ASCIIToUTF16("a2.com")); 351 shim->RenameBookmark(partner_bookmark1, base::ASCIIToUTF16("a2.com"));
352 shim->RemoveBookmark(partner_bookmark2); 352 shim->RemoveBookmark(partner_bookmark2);
353 EXPECT_EQ(ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1)); 353 EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1));
354 EXPECT_FALSE(shim->IsReachable(partner_bookmark2)); 354 EXPECT_FALSE(shim->IsReachable(partner_bookmark2));
355 } 355 }
356 356
357 PartnerBookmarksShim::ClearInBrowserContextForTesting(profile_.get()); 357 PartnerBookmarksShim::ClearInBrowserContextForTesting(profile_.get());
358 358
359 { 359 {
360 PartnerBookmarksShim* shim = partner_bookmarks_shim(); 360 PartnerBookmarksShim* shim = partner_bookmarks_shim();
361 shim->AddObserver(&observer_); 361 shim->AddObserver(&observer_);
362 362
363 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0); 363 EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
364 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0); 364 EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
365 ASSERT_TRUE(shim->IsLoaded()); 365 ASSERT_TRUE(shim->IsLoaded());
366 366
367 const BookmarkNode* partner_bookmark1 = shim->GetNodeByID(3); 367 const BookmarkNode* partner_bookmark1 = shim->GetNodeByID(3);
368 const BookmarkNode* partner_bookmark2 = shim->GetNodeByID(5); 368 const BookmarkNode* partner_bookmark2 = shim->GetNodeByID(5);
369 369
370 EXPECT_EQ(ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1)); 370 EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1));
371 EXPECT_FALSE(shim->IsReachable(partner_bookmark2)); 371 EXPECT_FALSE(shim->IsReachable(partner_bookmark2));
372 } 372 }
373 } 373 }
OLDNEW
« no previous file with comments | « chrome/browser/accessibility/accessibility_extension_apitest.cc ('k') | chrome/browser/android/dev_tools_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698