Issue 1090083002: [android-webview] Skip signal handler registration on x86/64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1090083002: [android-webview] Skip signal handler registration on x86/64 (Closed)

Created:
5 years, 8 months ago by Torne

Modified:
5 years, 8 months ago

Reviewers:
Primiano Tucci (use gerrit)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

More Reviews

Description

[android-webview] Skip signal handler registration on x86/64 An intricate entangling of libsigchain, sigaction() chaining and user-space SIGSEGV handling by binary translator cause persistent crashes when a SIGSEGV handler is installed by a x86 library on a hybrid application which uses both Arm and x86 libraries. Backing out the crash handler as a temporary workaround. More context in the related bug. BUG=477444 Review URL: https://codereview.chromium.org/1059543003 Cr-Commit-Position: refs/heads/master@{#325441} (cherry picked from commit c62077fbce7d6b2bdaa78b809498b740a3ae90f7) TBR=primiano@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/023395bc4bde5a15980f26072a3312ac6d5243d1

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	android_webview/common/aw_crash_handler.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Torne

5 years, 8 months ago (2015-04-16 22:18:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
023395bc4bde5a15980f26072a3312ac6d5243d1 (presubmit successful).

Expand Messages | Collapse Messages