Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1059543003: [android-webview] Skip signal handler registration on x86/64 (Closed)

Created:
5 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android-webview] Skip signal handler registration on x86/64 An intricate entangling of libsigchain, sigaction() chaining and user-space SIGSEGV handling by binary translator cause persistent crashes when a SIGSEGV handler is installed by a x86 library on a hybrid application which uses both Arm and x86 libraries. Backing out the crash handler as a temporary workaround. More context in the related bug. BUG=477444 Committed: https://crrev.com/c62077fbce7d6b2bdaa78b809498b740a3ae90f7 Cr-Commit-Position: refs/heads/master@{#325441}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M android_webview/common/aw_crash_handler.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Primiano Tucci (use gerrit)
Torne, this is part of a set of two cls (one for microdumps the other ...
5 years, 8 months ago (2015-04-15 21:44:25 UTC) #2
Primiano Tucci (use gerrit)
Torne, this is part of a set of two cls (one for microdumps the other ...
5 years, 8 months ago (2015-04-15 21:44:26 UTC) #3
Torne
lgtm
5 years, 8 months ago (2015-04-16 13:44:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059543003/20001
5 years, 8 months ago (2015-04-16 13:45:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 14:21:05 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 14:21:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c62077fbce7d6b2bdaa78b809498b740a3ae90f7
Cr-Commit-Position: refs/heads/master@{#325441}

Powered by Google App Engine
This is Rietveld 408576698