Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: android_webview/common/aw_crash_handler.cc

Issue 1090083002: [android-webview] Skip signal handler registration on x86/64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2311
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/common/aw_crash_handler.cc
diff --git a/android_webview/common/aw_crash_handler.cc b/android_webview/common/aw_crash_handler.cc
index 7dcdc9d5533fa816ed21694f40d7cc08f380960f..bbdc61b24689733d533dd7b14a570ee50518c0d6 100644
--- a/android_webview/common/aw_crash_handler.cc
+++ b/android_webview/common/aw_crash_handler.cc
@@ -11,6 +11,7 @@
#include <unistd.h>
#include "base/logging.h"
+#include "build/build_config.h"
namespace {
@@ -66,6 +67,13 @@ namespace android_webview {
namespace crash_handler {
void RegisterCrashHandler(const std::string& version) {
+#if defined(ARCH_CPU_X86_FAMILY)
+ // Don't install signal handler on X86/64 because this breaks binary
+ // translators that handle SIGSEGV in userspace and get chained after our
+ // handler. See crbug.com/477444
+ return;
+#endif
+
if (crash_handler_registered) {
NOTREACHED();
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698