Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.cpp

Issue 1089813002: Change beforeinstallprompt event to take an array of platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/app_banner/BeforeInstallPromptEvent.cpp
diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.cpp b/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
index 47f5b7739b21a376f2f9a25cb723dd4bf9534b84..53435b52067f660d0a7f8e686d0798e32dbefdc2 100644
--- a/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
@@ -16,15 +16,14 @@ BeforeInstallPromptEvent::BeforeInstallPromptEvent()
{
}
-BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, const String& platform)
+BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, const Vector<String>& platforms)
: Event(name, false, true)
- , m_platform(platform)
+ , m_platforms(platforms)
{
}
BeforeInstallPromptEvent::BeforeInstallPromptEvent(const AtomicString& name, const BeforeInstallPromptEventInit& init)
: Event(name, false, true)
- , m_platform(init.platform())
mlamouri (slow - plz ping) 2015/04/16 10:32:21 , m_platforms(init.platforms())
mlamouri (slow - plz ping) 2015/04/16 13:33:27 Keep this.
mlamouri (slow - plz ping) 2015/04/16 13:34:01 I realise that might not be clear. I mean that thi
benwells 2015/04/17 06:58:53 Done.
{
}
@@ -32,9 +31,9 @@ BeforeInstallPromptEvent::~BeforeInstallPromptEvent()
{
}
-String BeforeInstallPromptEvent::platform() const
+Vector<String> BeforeInstallPromptEvent::platforms() const
{
- return m_platform;
+ return m_platforms;
}
ScriptPromise BeforeInstallPromptEvent::userChoice(ScriptState* scriptState) const

Powered by Google App Engine
This is Rietveld 408576698