Source/modules/app_banner/BeforeInstallPromptEventInit.idl - Issue 1089813002: Change beforeinstallprompt event to take an array of platforms.

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEventInit.idl

Issue 1089813002: Change beforeinstallprompt event to take an array of platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('K') | « Source/modules/app_banner/BeforeInstallPromptEvent.idl ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/app_banner/BeforeInstallPromptEventInit.idl

diff --git a/Source/modules/app_banner/BeforeInstallPromptEventInit.idl b/Source/modules/app_banner/BeforeInstallPromptEventInit.idl

index 5fac0385bbc7f9eb5d4ec14dee29c984c248d400..13b24c82fa7b8f02814e8a4192f772b381438a05 100644

--- a/Source/modules/app_banner/BeforeInstallPromptEventInit.idl

+++ b/Source/modules/app_banner/BeforeInstallPromptEventInit.idl

@@ -3,5 +3,4 @@

// found in the LICENSE file.

dictionary BeforeInstallPromptEventInit : EventInit {

- DOMString platform = "web";

mlamouri (slow - plz ping) 2015/04/16 10:32:21 DOMString[] platforms = [];

benwells 2015/04/16 11:39:59 I tried that but got an error in the v8 code gener

I tried that but got an error in the v8 code generator at compile time. Any ideas? This is the error: FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Debug/gen/blink/bindings/scripts --output-dir ../../../../../../out/Debug/gen/blink/bindings/modules/v8 --info-dir ../../../../../../out/Debug/gen/blink/bindings/ --target-component modules --write-file-only-if-changed 1 "../../../modules/app_banner/BeforeInstallPromptEventInit.idl" Traceback (most recent call last): File "../../scripts/idl_compiler.py", line 202, in <module> sys.exit(main()) File "../../scripts/idl_compiler.py", line 198, in main generate_bindings(options, input_filename) File "../../scripts/idl_compiler.py", line 156, in generate_bindings idl_compiler.compile_file(input_filename) File "../../scripts/idl_compiler.py", line 134, in compile_file self.compile_and_write(idl_filename) File "../../scripts/idl_compiler.py", line 117, in compile_and_write target_definitions, interface_name) File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", line 183, in generate_code return self.generate_code_internal(definitions, definition_name) File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", line 208, in generate_code_internal definitions.dictionaries[definition_name]) File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", line 265, in generate_dictionary_code dictionary, interfaces_info) File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", line 62, in dictionary_context key=operator.attrgetter('name'))], File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", line 100, in member_context cpp_default_value, v8_default_value = default_values() File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", line 94, in default_values member.default_value) TypeError: 'NoneType' object is not callable

mlamouri (slow - plz ping) 2015/04/16 13:33:27 Checking the spec and asking the editor, it's actu

On 2015/04/16 at 11:39:59, benwells wrote: > On 2015/04/16 10:32:21, Mounir Lamouri wrote: > > DOMString[] platforms = []; > > I tried that but got an error in the v8 code generator at compile time. Any ideas? This is the error: > > FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Debug/gen/blink/bindings/scripts --output-dir ../../../../../../out/Debug/gen/blink/bindings/modules/v8 --info-dir ../../../../../../out/Debug/gen/blink/bindings/ --target-component modules --write-file-only-if-changed 1 "../../../modules/app_banner/BeforeInstallPromptEventInit.idl" > Traceback (most recent call last): > File "../../scripts/idl_compiler.py", line 202, in <module> > sys.exit(main()) > File "../../scripts/idl_compiler.py", line 198, in main > generate_bindings(options, input_filename) > File "../../scripts/idl_compiler.py", line 156, in generate_bindings > idl_compiler.compile_file(input_filename) > File "../../scripts/idl_compiler.py", line 134, in compile_file > self.compile_and_write(idl_filename) > File "../../scripts/idl_compiler.py", line 117, in compile_and_write > target_definitions, interface_name) > File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", line 183, in generate_code > return self.generate_code_internal(definitions, definition_name) > File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", line 208, in generate_code_internal > definitions.dictionaries[definition_name]) > File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", line 265, in generate_dictionary_code > dictionary, interfaces_info) > File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", line 62, in dictionary_context > key=operator.attrgetter('name'))], > File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", line 100, in member_context > cpp_default_value, v8_default_value = default_values() > File "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", line 94, in default_values > member.default_value) > TypeError: 'NoneType' object is not callable

Checking the spec and asking the editor, it's actually not possible to have default values for dictionary :( Please keep: DOMString[] platforms;

benwells 2015/04/17 06:58:53 Done.

On 2015/04/16 13:33:27, Mounir Lamouri wrote: > On 2015/04/16 at 11:39:59, benwells wrote: > > On 2015/04/16 10:32:21, Mounir Lamouri wrote: > > > DOMString[] platforms = []; > > > > I tried that but got an error in the v8 code generator at compile time. Any > ideas? This is the error: > > > > FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python > ../../scripts/idl_compiler.py --cache-dir > ../../../../../../out/Debug/gen/blink/bindings/scripts --output-dir > ../../../../../../out/Debug/gen/blink/bindings/modules/v8 --info-dir > ../../../../../../out/Debug/gen/blink/bindings/ --target-component modules > --write-file-only-if-changed 1 > "../../../modules/app_banner/BeforeInstallPromptEventInit.idl" > > Traceback (most recent call last): > > File "../../scripts/idl_compiler.py", line 202, in <module> > > sys.exit(main()) > > File "../../scripts/idl_compiler.py", line 198, in main > > generate_bindings(options, input_filename) > > File "../../scripts/idl_compiler.py", line 156, in generate_bindings > > idl_compiler.compile_file(input_filename) > > File "../../scripts/idl_compiler.py", line 134, in compile_file > > self.compile_and_write(idl_filename) > > File "../../scripts/idl_compiler.py", line 117, in compile_and_write > > target_definitions, interface_name) > > File > "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", > line 183, in generate_code > > return self.generate_code_internal(definitions, definition_name) > > File > "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", > line 208, in generate_code_internal > > definitions.dictionaries[definition_name]) > > File > "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py", > line 265, in generate_dictionary_code > > dictionary, interfaces_info) > > File > "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", > line 62, in dictionary_context > > key=operator.attrgetter('name'))], > > File > "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", > line 100, in member_context > > cpp_default_value, v8_default_value = default_values() > > File > "/usr/local/google/home/benwells/Projects/clankium/src/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py", > line 94, in default_values > > member.default_value) > > TypeError: 'NoneType' object is not callable > > Checking the spec and asking the editor, it's actually not possible to have > default values for dictionary :( > > Please keep: > DOMString[] platforms;

Done.

};