chrome/browser/ui/webui/options/clear_browser_data_handler.cc - Issue 10898002: Refactor BrowsingDataRemover creation for clarity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Markus' feedback. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

index 73e73b0c901f7e5d45fd522b8103ceee545a65d2..d1bd73e1846435aae87159da938b6bc6732cbe27 100644

--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

@@ -144,9 +144,8 @@ void ClearBrowserDataHandler::HandleClearBrowserData(const ListValue* value) {

// BrowsingDataRemover deletes itself when done.

int period_selected = prefs->GetInteger(prefs::kDeleteTimePeriod);

- remover_ = new BrowsingDataRemover(profile,

- static_cast<BrowsingDataRemover::TimePeriod>(period_selected),

- base::Time::Now());

+ remover_ = BrowsingDataRemover::CreateForPeriod(profile,

+ static_cast<BrowsingDataRemover::TimePeriod>(period_selected));

remover_->AddObserver(this);

remover_->Remove(remove_mask, origin_mask);

}