chrome/browser/ui/webui/net_internals/net_internals_ui.cc - Issue 10898002: Refactor BrowsingDataRemover creation for clarity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Markus' feedback. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

index de3b2e3d7fd731fbbe79e743778e996755be5b89..92c52d56a68bcb6ab0fc40492a3450f8eb04ebb9 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

@@ -719,10 +719,8 @@ void NetInternalsMessageHandler::OnRendererReady(const ListValue* list) {

}

void NetInternalsMessageHandler::OnClearBrowserCache(const ListValue* list) {

- BrowsingDataRemover* remover =

- new BrowsingDataRemover(Profile::FromWebUI(web_ui()),

- BrowsingDataRemover::EVERYTHING,

- base::Time::Now());

+ BrowsingDataRemover* remover = BrowsingDataRemover::CreateForUnboundedRange(

+ Profile::FromWebUI(web_ui()));

remover->Remove(BrowsingDataRemover::REMOVE_CACHE,

BrowsingDataHelper::UNPROTECTED_WEB);

// BrowsingDataRemover deletes itself.