Refactor BrowsingDataRemover creation for clarity.

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index add0506263c805954ad5693abf2c3e8889d8bb51..1bd915fc65fce2a13050ba8a43cc92cf2b70b6ae 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1595,9 +1595,8 @@ void ChromeContentBrowserClient::BrowserURLHandlerCreated(
 void ChromeContentBrowserClient::ClearCache(RenderViewHost* rvh) {
   Profile* profile = Profile::FromBrowserContext(
       rvh->GetSiteInstance()->GetProcess()->GetBrowserContext());
-  BrowsingDataRemover* remover = new BrowsingDataRemover(profile,
-      BrowsingDataRemover::EVERYTHING,
-      base::Time::Now());
+  BrowsingDataRemover* remover =
+      BrowsingDataRemover::CreateForUnboundedRange(profile);
   remover->Remove(BrowsingDataRemover::REMOVE_CACHE,
                   BrowsingDataHelper::UNPROTECTED_WEB);
   // BrowsingDataRemover takes care of deleting itself when done.
@@ -1606,9 +1605,8 @@ void ChromeContentBrowserClient::ClearCache(RenderViewHost* rvh) {
 void ChromeContentBrowserClient::ClearCookies(RenderViewHost* rvh) {
   Profile* profile = Profile::FromBrowserContext(
       rvh->GetSiteInstance()->GetProcess()->GetBrowserContext());
-  BrowsingDataRemover* remover = new BrowsingDataRemover(profile,
-      BrowsingDataRemover::EVERYTHING,
-      base::Time::Now());
+  BrowsingDataRemover* remover = BrowsingDataRemover::CreateForPeriod(profile,

[jam, 2012/08/28 16:13:04]

I'm confused about this change, the previous two calls had the same parameters,
but now you're calling two different functions?

[Mike West, 2012/09/03 08:02:57]

No, you're right: this should also be calling CreateForUnboundedRange. I'll fix
it up.

+      BrowsingDataRemover::EVERYTHING);
   int remove_mask = BrowsingDataRemover::REMOVE_SITE_DATA;
   remover->Remove(remove_mask, BrowsingDataHelper::UNPROTECTED_WEB);
   // BrowsingDataRemover takes care of deleting itself when done.