Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1089363002: Fix signed/unsigned compare in messages.cc (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix signed/unsigned compare in messages.cc R=machenbach@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2e0cf57804ab803a0af6059c8f74926d10af505b Cr-Commit-Position: refs/heads/master@{#27865}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/messages.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 8 months ago (2015-04-16 07:44:11 UTC) #1
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-16 07:46:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089363002/1
5 years, 8 months ago (2015-04-16 07:58:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 07:59:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e0cf57804ab803a0af6059c8f74926d10af505b Cr-Commit-Position: refs/heads/master@{#27865}
5 years, 8 months ago (2015-04-16 08:00:00 UTC) #6
Sven Panne
5 years, 8 months ago (2015-04-16 10:05:59 UTC) #8
Message was sent while issue was closed.
DBN (drive-by nit ;-)

https://codereview.chromium.org/1089363002/diff/1/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/1089363002/diff/1/src/messages.cc#newcode188
src/messages.cc:188: unsigned int i = 0;
Actually, this should be size_t...

Powered by Google App Engine
This is Rietveld 408576698