src/messages.cc - Issue 1089363002: Fix signed/unsigned compare in messages.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 1089363002: Fix signed/unsigned compare in messages.cc (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index fd6dae86eced868bb313264367aff4e8746cf3ca..c39f4e684800b7f3266d3202dd89c95f93d888c4 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -185,7 +185,7 @@ MaybeHandle<String> MessageTemplate::FormatMessage(int template_index,

Isolate* isolate = arg0->GetIsolate();

IncrementalStringBuilder builder(isolate);

- int i = 0;

+ unsigned int i = 0;

Sven Panne 2015/04/16 10:05:58 Actually, this should be size_t...

Handle<String> args[] = {arg0, arg1, arg2};

for (const char* c = template_string; *c != '\0'; c++) {

if (*c == '%') {

« no previous file with comments | « no previous file | no next file » | no next file with comments »