Fix signed/unsigned compare in messages.cc

src/messages.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/api.h"
 #include "src/execution.h"
 #include "src/heap/spaces-inl.h"
 #include "src/messages.h"
@@ skipping 167 matching lines @@
     case kLastMessage:
     default:
       UNREACHABLE();
       template_string = "";
       break;
   }
 
   Isolate* isolate = arg0->GetIsolate();
   IncrementalStringBuilder builder(isolate);
 
-  int i = 0;
+  unsigned int i = 0;

[Sven Panne, 2015/04/16 10:05:58]

Actually, this should be size_t...

   Handle<String> args[] = {arg0, arg1, arg2};
   for (const char* c = template_string; *c != '\0'; c++) {
     if (*c == '%') {
       builder.AppendString(args[i++]);
       DCHECK(i < arraysize(args));
     } else {
       builder.AppendCharacter(*c);
     }
   }
 
   return builder.Finish();
 }
 } }  // namespace v8::internal