Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1089063002: Don't draw if SkShader::asNewFragmentProcessor fails. (Closed)

Created:
5 years, 8 months ago by bsalomon
Modified:
5 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't draw if SkShader::asNewFragmentProcessor fails. BUG=chromium:473156 Committed: https://skia.googlesource.com/skia/+/bed83a66f5fa5821a3a08da32157a6155960b15e

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : upload again #

Patch Set 4 : whitespace #

Patch Set 5 : fix crash in pipe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -36 lines) Patch
A gm/badpaint.cpp View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
M gm/constcolorprocessor.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 15 chunks +57 lines, -22 lines 0 comments Download
M src/gpu/SkGr.cpp View 6 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
bsalomon
e
5 years, 8 months ago (2015-04-15 13:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089063002/60001
5 years, 8 months ago (2015-04-15 13:50:27 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-15 13:50:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/300)
5 years, 8 months ago (2015-04-15 14:01:53 UTC) #7
egdaniel
lgtm
5 years, 8 months ago (2015-04-15 14:14:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089063002/60001
5 years, 8 months ago (2015-04-15 14:20:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/306)
5 years, 8 months ago (2015-04-15 14:32:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089063002/60001
5 years, 8 months ago (2015-04-15 19:29:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/322)
5 years, 8 months ago (2015-04-15 19:47:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089063002/80001
5 years, 8 months ago (2015-04-15 21:12:22 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:18:38 UTC) #20
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/bed83a66f5fa5821a3a08da32157a6155960b15e

Powered by Google App Engine
This is Rietveld 408576698