Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1088993003: Replace OVERRIDE->override and FINAL->final since we now require C++11. (Closed)

Created:
5 years, 8 months ago by rmcilroy
Modified:
5 years, 8 months ago
CC:
Paweł Hajdan Jr., v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace OVERRIDE->override and FINAL->final since we now require C++11. R=jochen@chromium.org Committed: https://crrev.com/063fc25122d2e569785587ff1bd13fa5c3e185ba Cr-Commit-Position: refs/heads/master@{#27937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3551 lines, -3607 lines) Patch
M include/v8config.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/arm/lithium-arm.h View 148 chunks +207 lines, -209 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/arm64/lithium-arm64.h View 151 chunks +218 lines, -221 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/assert-scope.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ast.h View 99 chunks +223 lines, -225 lines 0 comments Download
M src/ast.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ast-numbering.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ast-value-factory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ast-value-factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/base/compiler-specific.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/base/cpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/cpu.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/flags.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/condition-variable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/base/platform/elapsed-timer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/mutex.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/base/platform/semaphore.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/time.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/base/platform/time.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/base/sys-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/utils/random-number-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/code-factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 70 chunks +121 lines, -121 lines 0 comments Download
M src/compilation-statistics.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/code-generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-node-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/common-operator.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/common-operator-reducer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/control-builders.h View 9 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/control-equivalence.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/control-flow-optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/gap-resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-reducer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 9 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/instruction-selector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-context-specialization.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-inlining.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 7 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-type-feedback.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/load-elimination.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/move-optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.h View 11 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/node-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-matchers.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.h View 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/register-allocator-verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/schedule.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/select-lowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/source-position.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/source-position.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/value-numbering-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/zone-pool.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/d8.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/elements.cc View 17 chunks +18 lines, -18 lines 0 comments Download
M src/execution.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/field-index.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 25 chunks +39 lines, -39 lines 0 comments Download
M src/hydrogen-gvn.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-gvn.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 263 chunks +569 lines, -577 lines 0 comments Download
M src/hydrogen-types.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 143 chunks +205 lines, -206 lines 0 comments Download
M src/ic/ic.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ic-state.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/libplatform/worker-thread.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.h View 7 chunks +8 lines, -8 lines 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 145 chunks +205 lines, -207 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 14 chunks +36 lines, -36 lines 0 comments Download
M src/mips64/lithium-gap-resolver-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-mips64.h View 144 chunks +204 lines, -207 lines 0 comments Download
M src/objects.cc View 14 chunks +28 lines, -30 lines 0 comments Download
M src/objects-inl.h View 9 chunks +15 lines, -15 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 14 chunks +39 lines, -39 lines 0 comments Download
M src/ppc/lithium-gap-resolver-ppc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/lithium-ppc.h View 147 chunks +206 lines, -206 lines 0 comments Download
M src/preparser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/prettyprinter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/prettyprinter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/property.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scanner-character-streams.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/snapshot/serialize.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/snapshot/snapshot-source-sink.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/type-feedback-vector.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/typing.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/unique.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 15 chunks +39 lines, -39 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 144 chunks +205 lines, -207 lines 0 comments Download
M src/x87/code-stubs-x87.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 16 chunks +39 lines, -39 lines 0 comments Download
M src/x87/lithium-gap-resolver-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.h View 143 chunks +207 lines, -208 lines 0 comments Download
M src/zone.h View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/base/platform/condition-variable-unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/base/platform/platform-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/base/platform/semaphore-unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/control-flow-optimizer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/liveness-analyzer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-matchers-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 79 chunks +86 lines, -86 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/libplatform/task-queue-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/run-all-unittests.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
rmcilroy
Jochen: could you please take a look, thanks. I would appreciate a quick review please, ...
5 years, 8 months ago (2015-04-20 11:01:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-20 11:06:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088993003/1
5 years, 8 months ago (2015-04-20 11:14:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5018)
5 years, 8 months ago (2015-04-20 11:42:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088993003/1
5 years, 8 months ago (2015-04-20 12:01:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088993003/1
5 years, 8 months ago (2015-04-20 12:28:43 UTC) #14
rmcilroy
Committed patchset #1 (id:1) manually as 063fc25122d2e569785587ff1bd13fa5c3e185ba (presubmit successful).
5 years, 8 months ago (2015-04-20 13:08:46 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 13:08:48 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/063fc25122d2e569785587ff1bd13fa5c3e185ba
Cr-Commit-Position: refs/heads/master@{#27937}

Powered by Google App Engine
This is Rietveld 408576698