Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ast-value-factory.cc

Issue 1088993003: Replace OVERRIDE->override and FINAL->final since we now require C++11. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast-value-factory.h ('k') | src/base/compiler-specific.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 int pos_; 49 int pos_;
50 }; 50 };
51 51
52 } 52 }
53 53
54 class AstRawStringInternalizationKey : public HashTableKey { 54 class AstRawStringInternalizationKey : public HashTableKey {
55 public: 55 public:
56 explicit AstRawStringInternalizationKey(const AstRawString* string) 56 explicit AstRawStringInternalizationKey(const AstRawString* string)
57 : string_(string) {} 57 : string_(string) {}
58 58
59 bool IsMatch(Object* other) OVERRIDE { 59 bool IsMatch(Object* other) override {
60 if (string_->is_one_byte_) 60 if (string_->is_one_byte_)
61 return String::cast(other)->IsOneByteEqualTo(string_->literal_bytes_); 61 return String::cast(other)->IsOneByteEqualTo(string_->literal_bytes_);
62 return String::cast(other)->IsTwoByteEqualTo( 62 return String::cast(other)->IsTwoByteEqualTo(
63 Vector<const uint16_t>::cast(string_->literal_bytes_)); 63 Vector<const uint16_t>::cast(string_->literal_bytes_));
64 } 64 }
65 65
66 uint32_t Hash() OVERRIDE { return string_->hash() >> Name::kHashShift; } 66 uint32_t Hash() override { return string_->hash() >> Name::kHashShift; }
67 67
68 uint32_t HashForObject(Object* key) OVERRIDE { 68 uint32_t HashForObject(Object* key) override {
69 return String::cast(key)->Hash(); 69 return String::cast(key)->Hash();
70 } 70 }
71 71
72 Handle<Object> AsHandle(Isolate* isolate) OVERRIDE { 72 Handle<Object> AsHandle(Isolate* isolate) override {
73 if (string_->is_one_byte_) 73 if (string_->is_one_byte_)
74 return isolate->factory()->NewOneByteInternalizedString( 74 return isolate->factory()->NewOneByteInternalizedString(
75 string_->literal_bytes_, string_->hash()); 75 string_->literal_bytes_, string_->hash());
76 return isolate->factory()->NewTwoByteInternalizedString( 76 return isolate->factory()->NewTwoByteInternalizedString(
77 Vector<const uint16_t>::cast(string_->literal_bytes_), string_->hash()); 77 Vector<const uint16_t>::cast(string_->literal_bytes_), string_->hash());
78 } 78 }
79 79
80 private: 80 private:
81 const AstRawString* string_; 81 const AstRawString* string_;
82 }; 82 };
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 bool AstValueFactory::AstRawStringCompare(void* a, void* b) { 372 bool AstValueFactory::AstRawStringCompare(void* a, void* b) {
373 const AstRawString* lhs = static_cast<AstRawString*>(a); 373 const AstRawString* lhs = static_cast<AstRawString*>(a);
374 const AstRawString* rhs = static_cast<AstRawString*>(b); 374 const AstRawString* rhs = static_cast<AstRawString*>(b);
375 if (lhs->is_one_byte() != rhs->is_one_byte()) return false; 375 if (lhs->is_one_byte() != rhs->is_one_byte()) return false;
376 if (lhs->hash() != rhs->hash()) return false; 376 if (lhs->hash() != rhs->hash()) return false;
377 int len = lhs->byte_length(); 377 int len = lhs->byte_length();
378 if (rhs->byte_length() != len) return false; 378 if (rhs->byte_length() != len) return false;
379 return memcmp(lhs->raw_data(), rhs->raw_data(), len) == 0; 379 return memcmp(lhs->raw_data(), rhs->raw_data(), len) == 0;
380 } 380 }
381 } } // namespace v8::internal 381 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast-value-factory.h ('k') | src/base/compiler-specific.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698