Issue 108813004: Added canvas.fillStyle with support for just the "#RRGGBB" style of colors.

Issue 108813004: Added canvas.fillStyle with support for just the "#RRGGBB" style of colors. (Closed)

Created:
7 years ago by jcgregorio

Modified:
7 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Added canvas.fillStyle with support for just the "#RRGGBB" style of colors. Also renamed drawRect to fillRect, which now take x,y,w,h parameters. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12621

Patch Set 1 #

Patch Set 2 : 80 cols #

Patch Set 3 : Fix more 80 cols #

Total comments: 26

Patch Set 4 : Review fixes. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -36 lines)			Patch
	M	experimental/SkV8Example/SkV8Example.h	View	1 2 3	5 chunks	+19 lines, -9 lines	0 comments	Download
	M	experimental/SkV8Example/SkV8Example.cpp	View	1 2 3	6 chunks	+81 lines, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits https://codereview.chromium.org/108813004/diff/40001/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/108813004/diff/40001/experimental/SkV8Example/SkV8Example.cpp#newcode109 experimental/SkV8Example/SkV8Example.cpp:109: // SkScalars. Maybe test if int ...

7 years ago (2013-12-11 16:45:46 UTC) #2

jcgregorio

https://codereview.chromium.org/108813004/diff/40001/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/108813004/diff/40001/experimental/SkV8Example/SkV8Example.cpp#newcode109 experimental/SkV8Example/SkV8Example.cpp:109: // SkScalars. Maybe test if int first? Not sure ...

7 years ago (2013-12-11 17:23:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/108813004/60001

7 years ago (2013-12-11 17:24:19 UTC) #4

Message was sent while issue was closed.

Change committed as 12621

Expand Messages | Collapse Messages