Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1087893004: Change SkPictureBuilder strategy to not create nested recorders (Closed)

Created:
5 years, 8 months ago by pdr.
Modified:
5 years, 8 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, Dominik Röttsches, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change SkPictureBuilder strategy to not create nested recorders This patch switches SkPictureBuilder to not record when slimming paint is enabled but instead to just use the display item list and later play it back to create a picture. Additionally, we now use a drawing recorder for masks which properly checks caching, fixing one class of crashers from [1]. [1] https://codereview.chromium.org/1087633002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193972

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/core/paint/SVGMaskPainter.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/platform/graphics/paint/SkPictureBuilder.h View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pdr.
5 years, 8 months ago (2015-04-17 20:47:29 UTC) #2
chrishtr
lgtm
5 years, 8 months ago (2015-04-17 20:52:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087893004/1
5 years, 8 months ago (2015-04-17 20:52:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087893004/20001
5 years, 8 months ago (2015-04-17 21:12:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087893004/20001
5 years, 8 months ago (2015-04-17 22:52:53 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-18 02:58:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193972

Powered by Google App Engine
This is Rietveld 408576698