[SP] Allocate an SkPictureRecorder only once per GraphicsContext instantiation

[SP] Allocate an SkPictureRecorder only once per GraphicsContext instantiation

This should be a lot faster than before, since Skia optimizes for
quickly allocating new SkCanvases within the same recorder.

BUG=470553
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193985

[chrishtr, 2015-04-13 21:20:13]

chrishtr@chromium.org changed reviewers:
+ mtklein@chromium.org

[f(malita), 2015-04-13 21:39:45]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2015-04-13 21:39:46]

https://codereview.chromium.org/1087633002/diff/1/Source/platform/graphics/Gr...
File Source/platform/graphics/GraphicsContext.h (right):

https://codereview.chromium.org/1087633002/diff/1/Source/platform/graphics/Gr...
Source/platform/graphics/GraphicsContext.h:446: OwnPtr<SkPictureRecorder>
m_pictureRecorder;
This has the same lifetime as GC - can we drop the OwnPtr wrapper and just store
a straight SkPictureRecorder instead?

[chrishtr, 2015-04-13 21:48:34]

https://codereview.chromium.org/1087633002/diff/1/Source/platform/graphics/Gr...
File Source/platform/graphics/GraphicsContext.h (right):

https://codereview.chromium.org/1087633002/diff/1/Source/platform/graphics/Gr...
Source/platform/graphics/GraphicsContext.h:446: OwnPtr<SkPictureRecorder>
m_pictureRecorder;
On 2015/04/13 at 21:39:45, f(malita) wrote:
> This has the same lifetime as GC - can we drop the OwnPtr wrapper and just
store a straight SkPictureRecorder instead?

Done.

[f(malita), 2015-04-13 21:52:31]

LGTM.

We should be able to get rid of the recording stack too, but it requires sorting
out some nesting issues first (I started on that a few days back, but run into
some complications and got distracted - need to pick it up again).

[chrishtr, 2015-04-13 21:57:00]

On 2015/04/13 at 21:52:31, fmalita wrote:
> LGTM.
> 
> We should be able to get rid of the recording stack too, but it requires
sorting out some nesting issues first (I started on that a few days back, but
run into some complications and got distracted - need to pick it up again).

Getting rid of the stack is a side-effect of SP also. (Mentioning to save you
time, since it'll come for free.)

[mtklein_C, 2015-04-13 21:58:59]

lgtm

[chrishtr, 2015-04-13 22:01:20]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-04-13 22:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087633002/20001

[commit-bot: I haz the power, 2015-04-14 00:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 00:06:33]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/59024)

[chrishtr, 2015-04-14 04:21:05]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-04-14 04:21:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/1087633002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-14 04:21:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087633002/40001

[commit-bot: I haz the power, 2015-04-14 04:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 04:41:45]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[chrishtr, 2015-04-14 16:29:14]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-04-14 16:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/1087633002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-14 16:29:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087633002/60001

[chrishtr, 2015-04-14 16:29:36]

I changed the code a little bit to account for cases where the GraphicsContext
is constructed with a non-null SkCanvas.

[chrishtr, 2015-04-14 21:42:09]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2015-04-14 21:42:10]

The failing tests are due to SVG filters using nested recordings within one
GraphicsContext, which is now illegal with Slimming Paint.

[commit-bot: I haz the power, 2015-04-14 23:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 23:17:33]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[pdr., 2015-04-17 00:14:13]

On 2015/04/14 at 23:17:33, commit-bot wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

This should be good to go once https://codereview.chromium.org/1089293002 lands

[pdr., 2015-04-17 05:45:41]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-04-17 05:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087633002/60001

[commit-bot: I haz the power, 2015-04-17 09:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 09:08:27]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/59604)

[pdr., 2015-04-18 14:32:01]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-04-18 14:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087633002/60001

[commit-bot: I haz the power, 2015-04-18 17:08:28]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193985

[pdr., 2015-04-18 22:23:58]

On 2015/04/18 at 17:08:28, commit-bot wrote:
> Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193985

Woohoo!