Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: Source/platform/graphics/paint/SkPictureBuilder.h

Issue 1087893004: Change SkPictureBuilder strategy to not create nested recorders (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/SVGMaskPainter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/SkPictureBuilder.h
diff --git a/Source/platform/graphics/paint/SkPictureBuilder.h b/Source/platform/graphics/paint/SkPictureBuilder.h
index fd81a5211f89cdf9eb75ee1372cc345cf2995d06..e3bb2b53a6c24a88f60a5770d1e90d1bd82a0708 100644
--- a/Source/platform/graphics/paint/SkPictureBuilder.h
+++ b/Source/platform/graphics/paint/SkPictureBuilder.h
@@ -19,28 +19,33 @@ class SkPictureBuilder {
STACK_ALLOCATED();
public:
SkPictureBuilder(const FloatRect& bounds)
+ : m_bounds(bounds)
{
if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
m_displayItemList = DisplayItemList::create();
m_context = adoptPtr(new GraphicsContext(m_displayItemList.get()));
} else {
m_context = GraphicsContext::deprecatedCreateWithCanvas(nullptr);
+ m_context->beginRecording(m_bounds);
}
- m_context->beginRecording(bounds);
}
GraphicsContext& context() { return *m_context; }
PassRefPtr<const SkPicture> endRecording()
{
- if (m_displayItemList)
- m_displayItemList->commitNewDisplayItemsAndReplay(*m_context);
+ if (!RuntimeEnabledFeatures::slimmingPaintEnabled())
+ return m_context->endRecording();
+
+ m_context->beginRecording(m_bounds);
+ m_displayItemList->commitNewDisplayItemsAndReplay(*m_context);
return m_context->endRecording();
}
private:
OwnPtr<DisplayItemList> m_displayItemList;
OwnPtr<GraphicsContext> m_context;
+ FloatRect m_bounds;
};
} // namespace blink
« no previous file with comments | « Source/core/paint/SVGMaskPainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698