[Download Notification] Refine retry logic when interrupted or cancelled

[Download Notification] Refine retry logic when interrupted or cancelled

Changes:
- Show "Retry" button only download is resume-able.
- Open chrome://downloads when user clicks a notification

BUG=477970
TEST=manually tested

Committed: https://crrev.com/876afae9cf3bbcb56cfcdd3032be9b85e5f4692a
Cr-Commit-Position: refs/heads/master@{#329797}

[yoshiki, 2015-04-17 23:25:27]

yoshiki@chromium.org changed reviewers:
+ benjhayden@chromium.org

[yoshiki, 2015-04-17 23:25:53]

benjhayden, could you take a look? Thanks.

[benjhayden, 2015-04-17 23:45:55]

On 2015/04/17 at 23:25:53, yoshiki wrote:
> benjhayden, could you take a look? Thanks.

I'm not sure if starting a new download is the right thing to do here, nor
whether this is completely the right way to do it.
Asanka will be back on Monday.

[yoshiki, 2015-04-20 16:28:09]

yoshiki@chromium.org changed reviewers:
+ asanka@chromium.org

[yoshiki, 2015-04-20 16:29:48]

Asanka, could you take a look? Thanks.

Ben, thank you for quick reply and letting me know Asanka's back.

[asanka, 2015-04-22 21:17:36]

https://codereview.chromium.org/1087843004/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_commands.cc (right):

https://codereview.chromium.org/1087843004/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_commands.cc:216:
download_item_->GetWebContents(), download_item_->GetURL()));
DownloadItem::GetWebContents() isn't guaranteed to return a non-null result.
This is going to fail for a substantial number of cases.

[yoshiki, 2015-05-13 16:31:03]

yoshiki@chromium.org changed reviewers:
- benjhayden@chromium.org

[yoshiki, 2015-05-13 16:40:09]

Asanka, as discussed in the mails, I updated the entire CL. PTAL again. Thanks.

[asanka, 2015-05-13 22:06:28]

On 2015/05/13 at 16:40:09, yoshiki wrote:
> Asanka, as discussed in the mails, I updated the entire CL. PTAL again.
Thanks.

Why is RETRY a separate action? Can't we just use RESUME?

[yoshiki, 2015-05-14 01:21:36]

On 2015/05/13 22:06:28, asanka wrote:
> On 2015/05/13 at 16:40:09, yoshiki wrote:
> > Asanka, as discussed in the mails, I updated the entire CL. PTAL again.
> Thanks.
> 
> Why is RETRY a separate action? Can't we just use RESUME?

I wanted to prepare a separate label and icon. But after the discussion with PM,
we can rephrase it to "Resume". So I removed the "Retry".

[yoshiki, 2015-05-14 01:21:45]

PTAL

https://codereview.chromium.org/1087843004/diff/40001/chrome/browser/download...
File chrome/browser/download/notification/download_notification_item.cc (right):

https://codereview.chromium.org/1087843004/diff/40001/chrome/browser/download...
chrome/browser/download/notification/download_notification_item.cc:406: id =
IDS_DOWNLOAD_LINK_RETRY;
Note that this string is still used by other places.

[asanka, 2015-05-14 03:09:41]

lgtm

[yoshiki, 2015-05-14 03:10:11]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-05-14 03:10:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087843004/60001

[commit-bot: I haz the power, 2015-05-14 04:08:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-14 04:09:30]

Patchset 4 (id:??) landed as
https://crrev.com/876afae9cf3bbcb56cfcdd3032be9b85e5f4692a
Cr-Commit-Position: refs/heads/master@{#329797}