chrome/browser/download/download_shelf_context_menu.cc - Issue 1087843004: [Download Notification] Refine retry logic when interrupted or cancelled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf_context_menu.cc

Issue 1087843004: [Download Notification] Refine retry logic when interrupted or cancelled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove RETRY and use RESUME instead Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_commands.cc ('k') | chrome/browser/download/notification/download_notification_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_shelf_context_menu.cc

diff --git a/chrome/browser/download/download_shelf_context_menu.cc b/chrome/browser/download/download_shelf_context_menu.cc

index 275050d099378d819da04484eec38788a197adfc..ab4836219d39ae0f4c13b692c9fe8ee0edeb0734 100644

--- a/chrome/browser/download/download_shelf_context_menu.cc

+++ b/chrome/browser/download/download_shelf_context_menu.cc

@@ -165,9 +165,6 @@ base::string16 DownloadShelfContextMenu::GetLabelForCommandId(

case DownloadCommands::LEARN_MORE_INTERRUPTED:

id = IDS_DOWNLOAD_MENU_LEARN_MORE_INTERRUPTED;

break;

- case DownloadCommands::RETRY:

- NOTREACHED();

- return base::string16();

}

CHECK(id != -1);

return l10n_util::GetStringUTF16(id);

« no previous file with comments | « chrome/browser/download/download_commands.cc ('k') | chrome/browser/download/notification/download_notification_item.h » ('j') | no next file with comments »