Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3484)

Unified Diff: chrome/browser/download/download_commands.cc

Issue 1087843004: [Download Notification] Refine retry logic when interrupted or cancelled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove RETRY and use RESUME instead Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_commands.h ('k') | chrome/browser/download/download_shelf_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_commands.cc
diff --git a/chrome/browser/download/download_commands.cc b/chrome/browser/download/download_commands.cc
index d571907609d85bbe39e03578f2b094781e295a14..52bfe0e931d04a2d17c396af546e45af6d0e2829 100644
--- a/chrome/browser/download/download_commands.cc
+++ b/chrome/browser/download/download_commands.cc
@@ -40,7 +40,6 @@ int DownloadCommands::GetCommandIconId(Command command) const {
return IDR_DOWNLOAD_NOTIFICATION_MENU_RESUME;
case SHOW_IN_FOLDER:
return IDR_DOWNLOAD_NOTIFICATION_MENU_FOLDER;
- case RETRY:
case KEEP:
return IDR_DOWNLOAD_NOTIFICATION_MENU_DOWNLOAD;
case DISCARD:
@@ -103,7 +102,6 @@ bool DownloadCommands::IsCommandEnabled(Command command) const {
case KEEP:
case LEARN_MORE_SCANNING:
case LEARN_MORE_INTERRUPTED:
- case RETRY:
return true;
}
NOTREACHED();
@@ -133,7 +131,6 @@ bool DownloadCommands::IsCommandChecked(Command command) const {
case CANCEL:
case DISCARD:
case KEEP:
- case RETRY:
case LEARN_MORE_SCANNING:
case LEARN_MORE_INTERRUPTED:
return false;
@@ -216,13 +213,6 @@ void DownloadCommands::ExecuteCommand(Command command) {
case RESUME:
download_item_->Resume();
break;
- case RETRY:
- if (download_item_->CanResume()) {
- download_item_->Resume();
- } else {
- // TODO(yoshiki): Implement retry logic.
- }
- break;
}
}
« no previous file with comments | « chrome/browser/download/download_commands.h ('k') | chrome/browser/download/download_shelf_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698